From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0BD923857C44 for ; Thu, 22 Jun 2023 13:17:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0BD923857C44 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687439870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qlT6NWnA117BtEp4OTwtH4P644YNxJpV+p4TmFJoWMM=; b=NdKmi20bOSEz53k/CZBE8ILgdlBxvz1GoaEgJlsGOfmxFCN69s1FpQYBFOn0bpf/Ll7lnU CahBh6c9/xmthXG4AiBDo0UNToMYS8oRpoIqC2wYnT/phWMMd8PiTfcmU8CusT83VsMgg0 oQJHf2Cf0CLD0RkRIYNX11WQJtR0YSM= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-180-vKSyxdusMF-EzVOPjjt5Fw-1; Thu, 22 Jun 2023 09:17:49 -0400 X-MC-Unique: vKSyxdusMF-EzVOPjjt5Fw-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-31283f4d22fso1150660f8f.2 for ; Thu, 22 Jun 2023 06:17:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687439868; x=1690031868; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qlT6NWnA117BtEp4OTwtH4P644YNxJpV+p4TmFJoWMM=; b=asSNPaI9qYqI8Klow6qEhYb9YU/DGEou0VBjuqTWrbNftkGhXy4s5UxqVOjEY6sDPl As1dQVFMgsU8EEIi93px/fnepiVSyoleQJQgf480Mm/UbkDDuKUkzpC+1cKh6pv1TS9Q 8IytPU6hSjXYUrEuN78KFD8VWkYJeANWLqsq5jSUbQEHMOLlxuejW+kz9vBsVpdQyhZu KDFE1AnsqHV273Bu2iBABUtGa7QCzwQz7AW/43Bd9CBdJw42ta0lB3SFCl6PLmYw83PB uPE2U4v0sbpcfeO72MHM/JbkdpGncl8oWqDcAZcAd/Csv10kDL4Ndnw/E6I/q1xsIzw9 jXAA== X-Gm-Message-State: AC+VfDz4ES93BuO7y+xv/9GhUoc/AikXFtr9+b8QwGppyMUtHDuzbbjW mBRW0Rpc3yZAR6IWVoFDJj2DCDRkZyiAYCUmBqFRyLw01s0l121y2ncVBYEFdsh+hBStCRceGQ+ lTjOclod9X92rxixSo8we9We5mzV+yvja7yziQcEjfezYpgq1FCYH/VwQcui2Sll291jCa6xW9c Y61RD5MA== X-Received: by 2002:a5d:5005:0:b0:309:5122:10a3 with SMTP id e5-20020a5d5005000000b00309512210a3mr12390678wrt.48.1687439868051; Thu, 22 Jun 2023 06:17:48 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5D7nMCdRkHZtQN3sFVxbLnEFfzosQFTMf5DqbzxQKC9g5FDeqnMztpGhLZ2xRWROUQy9w5GA== X-Received: by 2002:a5d:5005:0:b0:309:5122:10a3 with SMTP id e5-20020a5d5005000000b00309512210a3mr12390657wrt.48.1687439867711; Thu, 22 Jun 2023 06:17:47 -0700 (PDT) Received: from localhost (2.72.115.87.dyn.plus.net. [87.115.72.2]) by smtp.gmail.com with ESMTPSA id d4-20020a5d5384000000b003112b38fe90sm7048057wrv.79.2023.06.22.06.17.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 06:17:47 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 7/8] gdb/testsuite: remove use of sleep from gdb.base/foll-vfork.exp Date: Thu, 22 Jun 2023 14:17:27 +0100 Message-Id: <922bdad3d013b64bff34b43eecad1914ceebd8ec.1687438786.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: While working on gdb.base/foll-vfork.exp I noticed that there are several random 'sleep' calls throughout the test. The comment suggests these are to allow for output from a vforked child to arrive, but in each case the test is about to close and restart GDB, so I don't see how random output from a child process could impact testing. I removed the sleep calls and couldn't reproduce any failures from this test, I left the test running for a couple of hours, and tried loading my machine, and the test seems fine with these removed. I've left this as a separate commit so that if, in the future, someone can show that these are required, it will be easy to revert this one patch and bring them back. There should be no change in what is tested after this commit. --- gdb/testsuite/gdb.base/foll-vfork.exp | 48 --------------------------- 1 file changed, 48 deletions(-) diff --git a/gdb/testsuite/gdb.base/foll-vfork.exp b/gdb/testsuite/gdb.base/foll-vfork.exp index be0715b05c0..43fc25cc2c0 100644 --- a/gdb/testsuite/gdb.base/foll-vfork.exp +++ b/gdb/testsuite/gdb.base/foll-vfork.exp @@ -105,12 +105,6 @@ proc_with_prefix vfork_parent_follow_through_step { binfile srcfile } { pass $gdb_test_name } } - - # The child has been detached; allow time for any output it might - # generate to arrive, so that output doesn't get confused with - # any gdb_expected debugger output from a subsequent testpoint. - # - exec sleep 1 } proc_with_prefix vfork_parent_follow_to_bp { binfile srcfile } { @@ -127,12 +121,6 @@ proc_with_prefix vfork_parent_follow_to_bp { binfile srcfile } { pass $gdb_test_name } } - - # The child has been detached; allow time for any output it might - # generate to arrive, so that output doesn't get confused with - # any expected debugger output from a subsequent testpoint. - # - exec sleep 1 } proc_with_prefix vfork_child_follow_to_exit { binfile srcfile } { @@ -149,12 +137,6 @@ proc_with_prefix vfork_child_follow_to_exit { binfile srcfile } { pass $gdb_test_name } } - - # The parent has been detached; allow time for any output it might - # generate to arrive, so that output doesn't get confused with - # any gdb_expected debugger output from a subsequent testpoint. - # - exec sleep 1 } proc_with_prefix vfork_and_exec_child_follow_to_main_bp { binfile srcfile } { @@ -169,12 +151,6 @@ proc_with_prefix vfork_and_exec_child_follow_to_main_bp { binfile srcfile } { pass $gdb_test_name } } - - # The parent has been detached; allow time for any output it might - # generate to arrive, so that output doesn't get confused with - # any gdb_expected debugger output from a subsequent testpoint. - # - exec sleep 1 } proc_with_prefix vfork_and_exec_child_follow_through_step { binfile srcfile } { @@ -190,12 +166,6 @@ proc_with_prefix vfork_and_exec_child_follow_through_step { binfile srcfile } { pass $gdb_test_name } } - - # The parent has been detached; allow time for any output it might - # generate to arrive, so that output doesn't get confused with - # any expected debugger output from a subsequent testpoint. - # - exec sleep 1 } proc continue_to_vfork {} { @@ -229,12 +199,6 @@ proc_with_prefix tcatch_vfork_then_parent_follow { binfile srcfile } { exp_continue } } - - # The child has been detached; allow time for any output it might - # generate to arrive, so that output doesn't get confused with - # any expected debugger output from a subsequent testpoint. - # - exec sleep 1 } proc_with_prefix tcatch_vfork_then_child_follow_exec { binfile srcfile } { @@ -261,12 +225,6 @@ proc_with_prefix tcatch_vfork_then_child_follow_exec { binfile srcfile } { pass "$gdb_test_name (followed exec)" } } - - # The parent has been detached; allow time for any output it might - # generate to arrive, so that output doesn't get confused with - # any expected debugger output from a subsequent testpoint. - # - exec sleep 1 } proc tcatch_vfork_then_child_follow_exit { binfile srcfile } { @@ -291,12 +249,6 @@ proc tcatch_vfork_then_child_follow_exit { binfile srcfile } { exp_continue } } - - # The parent has been detached; allow time for any output it might - # generate to arrive, so that output doesn't get confused with - # any expected debugger output from a subsequent testpoint. - # - exec sleep 1 } proc_with_prefix vfork_relations_in_info_inferiors { variant binfile srcfile non_stop } { -- 2.25.4