Re: [RFA_v3 2/8] Implement frame apply [all | COUNT | -COUNT | id ID... ] [FLAG]... COMMAND.

[Pedro Alves <palves@redhat.com>]

On 06/24/2018 07:37 PM, Philippe Waroquiers wrote:
> Implement frame apply [all | COUNT | -COUNT | id ID... ] [FLAG]... COMMAND.
> Also implement the command 'faas COMMAND', a shortcut for
> 'frame apply all -s COMMAND'.
> 
> The syntax of 'frame apply' to specify some innermost or outermost
> frames is similar to 'backtrace' command, using COUNT or -COUNT.
> 
> To apply a COMMAND to a more specific set of frames, the following
> new command and syntax can be used:
> frame apply id ID... [FLAG]... COMMAND
> where ID is one or more frame ids or range of frame ids.

Thanks much for doing this.  Other than the "id" / "level"
thing, this looks mostly OK to me.  One minor detail below.

> +
> +/* Implementation of the "frame apply id" command.  */
> +
> +static void
> +frame_apply_id_command (const char *cmd, int from_tty)
> +{
> +  if (!target_has_stack)
> +    error (_("No stack."));
> +
> +  bool id_found = false;
> +  const char *ids = cmd;
> +  number_or_range_parser idls (ids);
> +
> +  /* Skip the ID list to find the flags and command args.  */
> +  while (!idls.finished ())
> +    {
> +      const int id_beg = idls.get_number ();
> +
> +      id_found = true;
> +      if (idls.in_range ())
> +	idls.skip_range ();
> +    }
> +
> +  if (!id_found)
> +    error (_("Missing or invalid ID... argument"));
> +
> +  cmd = idls.cur_tok ();
> +
> +  /* Redo the IDLS parsing, but applying COMMAND.  */
> +  idls.init (ids);
> +  while (!idls.finished ())
> +    {
> +      const int id_beg = idls.get_number ();
> +      int n_frames;
> +
> +      if (idls.in_range ())
> +	{
> +	  n_frames = idls.end_value () - id_beg + 1;
> +	  idls.skip_range ();
> +	}
> +      else
> +	n_frames = 1;
> +
> +      frame_apply_command_count ("frame apply id", cmd, from_tty,
> +				 leading_innermost_frame (id_beg), n_frames);

I noticed that as is, frame_apply_command_count is going to parse CMD
for parse_flags_qcs for every iteration.  I wonder whether it wouldn't
be clearer to split frame_apply_command_count after that CMD parsing
to a separate function that is called by both frame_apply_id_command
and frame_apply_command_count.

Thanks,
Pedro Alves