From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62060 invoked by alias); 4 Dec 2019 16:24:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 61858 invoked by uid 89); 4 Dec 2019 16:24:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Google-Smtp-Source:APXvYqw X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-1.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (205.139.110.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Dec 2019 16:24:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575476653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S+Tb563VSECbjjVZiDl7jzWIOLMX42ZP2Hm4laOdjR8=; b=fbI7Fx3/y7DFNheyC8eKbZrj098fqvdTtfCMJ7Rl4y3orpFplnWDMc3nCVH7xyTpuHeE98 INoWJZJ6ESFBZuh7AAyIJ7LtQbx34TbHKzFdvB8DQXqBsLFDRCIJUB40M8ziLRUzFbiZOg U+/t0yA8BlUd5pj81hbWoEm0xKjZz9U= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-30-uZ4iw2lbO9mZxaTHUKykjQ-1; Wed, 04 Dec 2019 11:24:12 -0500 Received: by mail-wr1-f71.google.com with SMTP id b2so88230wrj.9 for ; Wed, 04 Dec 2019 08:24:11 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id e18sm9917288wrw.70.2019.12.04.08.24.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Dec 2019 08:24:08 -0800 (PST) Subject: Re: [RFA] Implement 'print -raw-values' and 'set print raw-values on|off' To: Simon Marchi , Philippe Waroquiers , gdb-patches@sourceware.org References: <20190807193924.32268-1-philippe.waroquiers@skynet.be> <5b8685bb-465e-ef47-1dc0-0746f489f4f8@simark.ca> From: Pedro Alves Message-ID: <922dc754-deec-6650-f60e-7322599fc6c5@redhat.com> Date: Wed, 04 Dec 2019 16:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <5b8685bb-465e-ef47-1dc0-0746f489f4f8@simark.ca> X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-12/txt/msg00142.txt.bz2 On 12/4/19 3:43 AM, Simon Marchi wrote: > On 2019-08-07 3:39 p.m., Philippe Waroquiers wrote: >> The option framework documentation was speaking about a 'print -raw' >> option, but this option does not exist. Eh. I think I recall that it would be a good idea to have it, like I made "bt -full/-no-filters/-hide" options to supersede "bt full/no-filters/hide", but then dropped it for some reason. So +1 from me. (But see the other email I sent.) >> >> This patch implements -raw-values option that tells to ignore the >> active pretty printers when printing a value. >> As we already have -raw-frame-arguments, I thought -raw-values >> was more clear, in particular to differentiate >> set print raw-values and set print raw-frame-arguments. > > Hi Philippe, > > I'm just a bit worried about the naming, but I don't have anything better > to suggest. I mention it in case you do. The "set print raw-values" sounds > like superset of "set print raw-frame-arguments", because in my mind frame > arguments are printed as values. But isn't it a superset? > Other than that, the patch looks fine to me. Thanks, Pedro Alves