From: Pedro Alves <palves@redhat.com>
To: Keith Seitz <keiths@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Don't elide all inlined frames
Date: Wed, 16 May 2018 14:04:00 -0000 [thread overview]
Message-ID: <926806f6-7530-0276-a2ac-5aba95a4bff8@redhat.com> (raw)
In-Reply-To: <faa91346-8c53-ed35-f1a7-7705fc18c171@redhat.com>
On 05/14/2018 08:43 PM, Keith Seitz wrote:
> On 05/11/2018 08:55 AM, Pedro Alves wrote:
>> I was thinking of this comment:
>>
>> /* Breakpoint that caused the stop. This is nullified if the
>> breakpoint ends up being deleted. See comments on
>> `bp_location_at' above for why do we need this field instead of
>> following the location's owner. */
>> struct breakpoint *breakpoint_at;
>>
>> and noticed that the code uses "s->breakpoint_at" and somehow misread
>> it as still following the breakpoint's location list.
>
> Ah, yes, okay, your comments make much more sense now. ;-)
Yeah. Also thanks for spotting that the earlier comment about not
following the locations of the breakpoint (since the may not be
enabled/inserted) still applied, and fixing the patch. ;-)
This version is OK. Please push.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-05-16 13:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 20:33 Keith Seitz
2018-04-09 12:25 ` Pedro Alves
2018-05-09 19:17 ` Keith Seitz
2018-05-11 16:53 ` Pedro Alves
2018-05-15 0:11 ` Keith Seitz
2018-05-16 14:04 ` Pedro Alves [this message]
2018-05-17 21:23 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=926806f6-7530-0276-a2ac-5aba95a4bff8@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).