From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 285ED3858D28 for ; Tue, 31 Jan 2023 15:49:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 285ED3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 30VFnAWi019549 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 31 Jan 2023 10:49:15 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 30VFnAWi019549 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1675180155; bh=sbVgeU0z4Ap0OzNNrVsyNu/LuIfII+AqGHBVDcif/+0=; h=Date:Subject:To:References:From:In-Reply-To:From; b=cqJ5he2urHW9/vef4QeGexWSBIq4Z8lCHC9+1kOqsO1Wfz1lBC2qmFMSPe4B998zU Vkx6a2DHqVz9+HbFmVggMG91bRPLIGoLWYvS5N5PLoBd6J7QkUblEEneE9FeO/DXC8 hfFoIa3d0FUI0RjOye5FOf7hGrOcHsZ3QVSFCt/4= Received: from [172.16.0.192] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9EA111E0D3; Tue, 31 Jan 2023 10:49:10 -0500 (EST) Message-ID: <92a28fac-9d20-f0be-fd7e-b9ad8683c615@polymtl.ca> Date: Tue, 31 Jan 2023 10:49:10 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2] gdb/dwarf: dump cooked index contents in cooked_index_functions::dump Content-Language: fr To: Andrew Burgess , Simon Marchi , gdb-patches@sourceware.org References: <20230130160337.55890-1-simon.marchi@efficios.com> <87a61zvh7a.fsf@redhat.com> <03ff1644-df3d-2e6b-f2aa-49767abc580b@polymtl.ca> <877cx3uki5.fsf@redhat.com> From: Simon Marchi In-Reply-To: <877cx3uki5.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 31 Jan 2023 15:49:10 +0000 X-Spam-Status: No, score=-3031.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > I think this would be a good improvement. Especially the "No debugging > symbols found..." message now being printed, is, I think, a good thing. Although I agree with you, given Tom's answer, I will go with the simple nullptr check. Hopefully we can being back the "No debugging symbols found" message at some later point. Simon