From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 308623858CDA for ; Mon, 22 Apr 2024 18:47:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 308623858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 308623858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713811626; cv=none; b=Qe+JOXrDeN+zLlbdD33gEo9XwR1jhMpq5YI1OOR0krizxje18VH3zto5gP0wdwt4SruKrinKGANZvoACuxg3wjPwGZG+9I2UFLm23AcRLX2HDyadODrD7Nb2jQ1N7Pathwf/FCMuLznweqKdAQKoApSIJ6Ef+f2RfWUiGLdXdCI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713811626; c=relaxed/simple; bh=8aHSbzOtaaeSfgOqoapQBj14qaVvlZjJvkmfipTjYHY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=dd8WHxfEDpd2BGozlkh0WH1t6BgziFqOVrXP85ccOkJpgDJksI0c+ZKjP10uRIy1nar2cqYjrRakzbcJ+khdI+S2zTr79KzsW52P7q85IH2pBEOP6tHxnkZIWn/criObc3ZJA1pHaTFlkuAfEl2vgPC4DQ7raYe/HFziZyJAMjY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1713811623; bh=8aHSbzOtaaeSfgOqoapQBj14qaVvlZjJvkmfipTjYHY=; h=Date:Subject:To:References:From:In-Reply-To:From; b=febbiNJbdt7KwNCyPKe9a+5vdjQ+KaQDA3tpfHaXxhqxBCRYezp+LWEYK48R+OkHz FDFdaFr7LA2uHBOurFvdrycGrZ3AG1BApyMfDwQnLuXyI2vvvvH+a79Vhbk4btK4XJ 2oG5p6KID30WgadMk0JayAAQKuH9NAIyQiKY04aE= Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id AA9261E092; Mon, 22 Apr 2024 14:47:03 -0400 (EDT) Message-ID: <92ab0ed6-a53a-46af-a91d-ec652ba31bcb@simark.ca> Date: Mon, 22 Apr 2024 14:47:02 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fix leak with internal functions To: Tom Tromey , gdb-patches@sourceware.org References: <20240422180538.3067094-1-tromey@adacore.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20240422180538.3067094-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/22/24 2:05 PM, Tom Tromey wrote: > diff --git a/gdb/value.c b/gdb/value.c > index 1bd180a62cc..58e4a975485 100644 > --- a/gdb/value.c > +++ b/gdb/value.c > @@ -1882,6 +1882,11 @@ struct internalvar > : name (std::move (name)) > {} > > + ~internalvar () > + { > + clear_internalvar (this); > + } This struct should probably be made non-movable/assignable/copyable/etc (or the appropriate ones should be implemented, if they are needed). Simon