From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 074E33858421 for ; Tue, 20 Dec 2022 17:01:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 074E33858421 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671555703; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ebYV+IjO9WGAjSAPxXuiBHLHrl7bgkfdd6JjD6cACJ0=; b=FByD6kJtozkm19S20Dlnivr6jklOXIkxStfU2dKuEh2DftEjmhiJjG/qqiiqbgyY3hgk51 3Xo8C69f+poK3VXLE48IB6Yhxfbs2IRU7eaOtUFp0GqIXMOgJ030M/qA6NzcI23XQ0xu4F zKhi9Cvj81vHdB6F7+Ao6YRAApmvc6U= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-517-eRKE3jaLOFiDUSZmm-Mtmw-1; Tue, 20 Dec 2022 12:01:41 -0500 X-MC-Unique: eRKE3jaLOFiDUSZmm-Mtmw-1 Received: by mail-ed1-f72.google.com with SMTP id x13-20020a05640226cd00b0047ac11c9774so4353909edd.17 for ; Tue, 20 Dec 2022 09:01:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ebYV+IjO9WGAjSAPxXuiBHLHrl7bgkfdd6JjD6cACJ0=; b=ubVk+CzX15upBJWXsDZFb4DdAdf8KNCjGBS7PQnpShesNU0lvrQnOaS3VomgkFkNxN egx92mSuGUjA6bfb+pSMzF7H+CzPAhOmp5Xz9hlN1xOuLDRxeDrW5RTUid0+41kCJYZk AHic0oyNvsbDz/1KlxNWC4BHWX7abc1Tu0IGCBZVdiI6CJ8HDx3SwuaefeYYS6DB+SKn lxZP5hYY5BaTZZwQ/VvbdzyupkZLIBS6maep9Zpt8BB28416Qddjf4yLg33Wp91pkwfD 7RU4QWYS25boTCY1kHpNTLCR5yGt5dLW6TjFXATlUbi08BXjqwI5kQWW4iDhGgY3uZHE lLOA== X-Gm-Message-State: ANoB5plE+iSFAu+yBuL5PEcKzw1AuHmQIC+ZlV7icyAeIDnBAK4jV9Iq 5qarxOpnLDCzaneAj0QmtckiFxmed9HnkeJv+7m+uNn7VU4HI0Cv6Rjr12IV/MpbrBbOCHyb27E ZN3KiULRoJI234RFDSmKXeg== X-Received: by 2002:a17:906:33db:b0:7c1:435c:d777 with SMTP id w27-20020a17090633db00b007c1435cd777mr35309934eja.9.1671555700543; Tue, 20 Dec 2022 09:01:40 -0800 (PST) X-Google-Smtp-Source: AA0mqf5105QeSC4oyVqJV2EjmSSQNzOrBs3fuXb5h5f0gmHPXbXNlG+6zw6pYTGpn4iLUoJx4Smf/A== X-Received: by 2002:a17:906:33db:b0:7c1:435c:d777 with SMTP id w27-20020a17090633db00b007c1435cd777mr35309920eja.9.1671555700344; Tue, 20 Dec 2022 09:01:40 -0800 (PST) Received: from [192.168.0.45] (ip-62-245-66-121.bb.vodafone.cz. [62.245.66.121]) by smtp.gmail.com with ESMTPSA id kw16-20020a170907771000b007ba46867e6asm6014418ejc.16.2022.12.20.09.01.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Dec 2022 09:01:39 -0800 (PST) Message-ID: <92c0b9cf-41e4-08df-0212-e3b5e707bfe4@redhat.com> Date: Tue, 20 Dec 2022 18:01:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v2 06/13] gdb: move frame_info_ptr to frame.{c,h} To: Simon Marchi , gdb-patches@sourceware.org References: <20221214033441.499512-1-simon.marchi@polymtl.ca> <20221214033441.499512-7-simon.marchi@polymtl.ca> From: Bruno Larsen In-Reply-To: <20221214033441.499512-7-simon.marchi@polymtl.ca> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 14/12/2022 04:34, Simon Marchi via Gdb-patches wrote: > Change-Id: Ic5949759e6262ea0da6123858702d48fe5673fea > --- > gdb/Makefile.in | 1 - > gdb/c-lang.h | 1 + > gdb/dwarf2/call-site.h | 2 +- > gdb/frame-info.c | 65 ------------- > gdb/frame-info.h | 211 ----------------------------------------- > gdb/frame.c | 43 ++++++++- > gdb/frame.h | 188 +++++++++++++++++++++++++++++++++++- > gdb/gdbtypes.h | 2 - > gdb/symtab.h | 1 + > 9 files changed, 230 insertions(+), 284 deletions(-) > delete mode 100644 gdb/frame-info.c > delete mode 100644 gdb/frame-info.h Not sure if this is on purpose but this commit doesn't seem to have a commit message. If you'd like some extra context to write it, I ran into cyclic includes when writing the original version (which you found and fixed). Since I am not familiar with the rest of the code, a new file seemed like a good enough hack to get things working. Now that you solved the cyclic includes, it makes sense to remove the files. -- Cheers, Bruno