From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100126 invoked by alias); 20 Jun 2017 11:09:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100090 invoked by uid 89); 20 Jun 2017 11:09:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Jun 2017 11:09:35 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 985E9C04D294; Tue, 20 Jun 2017 11:09:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 985E9C04D294 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 985E9C04D294 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 001A7867BA; Tue, 20 Jun 2017 11:09:33 +0000 (UTC) Subject: Re: [PATCH 10/25] Adjust code generated by regformats/regdat.sh To: Yao Qi , gdb-patches@sourceware.org References: <1497256916-4958-1-git-send-email-yao.qi@linaro.org> <1497256916-4958-11-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <92ca03ca-e06d-09fc-7243-e52dd29edcef@redhat.com> Date: Tue, 20 Jun 2017 11:09:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1497256916-4958-11-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00566.txt.bz2 On 06/12/2017 09:41 AM, Yao Qi wrote: > regformats/regdat.sh generate some *-generated.c files when GDBserver > is built. Each .c file has some static variables, which are only used > within function init_registers_XXX, like this, > > static struct reg regs_i386_linux[] = { > { "eax", 0, 32 }, > { "ecx", 32, 32 }, > ... > }; > > static const char *expedite_regs_i386_linux[] = { "ebp", "esp", "eip", 0 }; > static const char *xmltarget_i386_linux = "i386-linux.xml"; > > void > init_registers_i386_linux (void) > { > ... > } > > This patch moves these static variables' definitions to function > init_registers_XXX, so the generated files look like this, > The rationale misses stating why is this better than the status quo. I presume this helps following patches? Thanks, Pedro Alves