From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id DC40C3858D34 for ; Wed, 21 Feb 2024 13:31:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DC40C3858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DC40C3858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708522279; cv=none; b=T1yoIOsmXhiXIWCpD8p8cNHuoPzknAE3Kfwwn5uKnI1xAyGB2LeDOT8nPxdRvj1jqCSJ45YLWgLsFVO7f6pGW3k+GTcvv61UkvKIkGd8diIMdtoxQaUWnVpcq9E0AuekgEkfzNmvrlJsht4fV8aBV93PuDihgqv6JgtQFvloZVM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708522279; c=relaxed/simple; bh=+wGseeJTyH3fljy6lOj8P94dmxf3KUs6WALM09EB+co=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=V4Ro+e5KyJyu6jNm+dewGcpWJX3t+oLTEF0rukyb7xYZ1jvbBNPOnc6bKXo67auDsa04YL3IWzDInyK4HtOTbcEu6Vh9IA6NHqvHQ9M17J1/84SCXfXzIE5Lhj6e39r8L31FI5f6tQyRrWmFyBJUapYgRJSKAR7jx4/4/b+sMck= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D6A5121EA7; Wed, 21 Feb 2024 13:31:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708522277; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i72Uj0gGiNd1Nj+XiaG0nli9N/YtIGqTSWZmSKYue38=; b=tUkyWpxzPVmeJV1huMnMEz/SuYl60vWziTUnxUseP+lzYpZHtWvQZZbXHzXKnI++ScfYY9 k8IHHrt7j91EXa1BmhWjIktT1QjW78jaAYubLiWooOAwGUUI5BT4+125dyg5F0Baw/l2zm JWdSakxw4tpB8VKe9pw93gluU2QC8/8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708522277; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i72Uj0gGiNd1Nj+XiaG0nli9N/YtIGqTSWZmSKYue38=; b=gPC6MsbHyGjK3wkfB8k6rcAG8Lld+7U8VR36xdYhRajXjv6nrW0RP6Rwc+5WgU3YlyldJX Xq0Wq6ElVN8HbIDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708522276; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i72Uj0gGiNd1Nj+XiaG0nli9N/YtIGqTSWZmSKYue38=; b=lmZndH50XMmqCViBtIcE/bmIlWz/BbizMOunzVGVw2DEWVh9xcG1nwl0ghU9w8d17bAzBp E1GlpmlKid7jregaB0u3e/M1QDOXq5/1QoiHM7iG78u0mTOU4YVrktU/uzZrYBqTg93S+/ yBSKt7H+hlIN8tG0yerlpmvOzUtOAGU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708522276; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i72Uj0gGiNd1Nj+XiaG0nli9N/YtIGqTSWZmSKYue38=; b=vPqPdgb1coO2iCNdMvfZR7TG6Xy/b7fZ16g2FFcdfjO/w95I0p/OSt1F9vvInSXrO9zOer 0WUTTkVW9ULX1+Bw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B45DD139D0; Wed, 21 Feb 2024 13:31:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 8B03KST71WVjdAAAD6G6ig (envelope-from ); Wed, 21 Feb 2024 13:31:16 +0000 Message-ID: <92d73bc7-1c1a-4ae2-a2c6-ed956418f28c@suse.de> Date: Wed, 21 Feb 2024 14:31:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/8] [gdb/dap] Make dap log printing thread-safe Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20240219082341.21313-1-tdevries@suse.de> <20240219082341.21313-4-tdevries@suse.de> <87edd72lu4.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87edd72lu4.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=lmZndH50; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=vPqPdgb1 X-Spamd-Result: default: False [-3.16 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-2.86)[99.41%]; MIME_GOOD(-0.10)[text/plain]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: D6A5121EA7 X-Spam-Level: X-Spam-Score: -3.16 X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/20/24 16:32, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> I read that printing from different python threads is thread-unsafe, and I > Tom> noticed that the dap log printing is used from different threads, but doesn't > Tom> take care to make the printing thread-safe. > > Tom> Fix this by using a lock to access LoggingParam.log_file. > > Ok. > Approved-By: Tom Tromey > > > I wonder if we should just switch to the Python logging module. > > Tom> - log_file = None > Tom> + lock = threading.Lock() > Tom> + with lock: > Tom> + log_file = None > > I can't imagine locking is needed here. Dropped that bit, and committed. Thanks, - Tom