Re: [PATCH] gdb/testsuite: Fix race in gdb.dwarf2/calling-convention.exp

[Lancelot SIX <Lancelot.Six@amd.com>]

Hi,

> This should escape the "?" in "now?" too, as '?' has special meaning in regexps.

Yes, this one should definitely be escaped.

> 
> The ".*" just before (y or n) isn't needed, right?
> 

TBH, this is a pattern I used from somewhere else… And at the moment is 
sort of is required because of the non-escaped "?" you mentioned just 
above.  If the "?" is escaped properly, the ".*" can (should) be 
replaced by a plain space " ".

>>        pass $gdb_test_name
>> +     gdb_test "n" "Not confirmed" "Cancel return"
> 
> Lowercase messages please.
> 
> Note gdb_test can handle this itself, it supports two extra arguments to handle questions.  Like so:

Thanks, I was not aware of this.  This indeed simplified the all thing 
even further, so it should be preferred.

> 
> gdb_test "return 35" \
>      "Not confirmed" \
>      "return 35" \
>      "Function 'foo' does not follow the target calling convention.\r\nIf you continue, setting the return value will probably lead to unpredictable behaviors.\r\nMake foo return now\\? \\(y or n\\) $" \
>      "n"
> 
> Note that if gdb doesn't print the question and prints "Not confirmed" straight away, the test will still pass, because
> the question is optional.  IMHO that's a gdb_test misfeature, though, which can lead to regressions without us noticing.
> I wrote a patch to change that, and it caught a number of wrong things in the testsuite.  I'll send it a bit later.

Great! Thanks for doing this.

Best,
Lancelot.