From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id 9DB133858D34 for ; Sat, 20 Apr 2024 20:27:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9DB133858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9DB133858D34 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2610:1c1:1:606c::19:2 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713644842; cv=pass; b=vV79Xfkm+mlLxjQ0ZCfJmNHxXxd/Hp5jwd/IR81kQVY58gk6RsaOIkVSIXKwwWw5mufgi8s1TqI552F1KNxQ4Zoge4iKe69gOHQNOVYLXexbeA+eZDiuKggVTmBjen9mExfzsLu0FBHTEP1QOu5kzbWgsNLSxr5OmDJt825aE9E= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713644842; c=relaxed/simple; bh=UCUEQmGyq2X20gjJzDcxVIgOvgaO/yWgdg6Y1l208og=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=WUGns9f5VslSjNkqHUoewz8yqRPt3m2OAV61Z6w1R4sXehZZopKtbePr9f0tsBlTbTpZtP8XCxN0svObjwJvH8z+OrnGQ1z7sVG8Qs7tK49BmfjAsUnyfEqYWYKnCqqUD+dwEzpviUpIO7/0glLR8ALKUwh+tfsxVywi9DD11k8= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4VMNNT3FRRz4nLS; Sat, 20 Apr 2024 20:27:21 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VMNNT2Nyqz4WGm; Sat, 20 Apr 2024 20:27:21 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713644841; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z15hNCrvowrbn/xo6jCsjvug4opdus56vAAK9Sv7un0=; b=R1L1by9lin7n0L3jRZ4N32xwpVWgrmvzBvo8Cd3qCn5OfDU+6KDAx/xMhUo1kg5CrvEwrZ HnrsfBgSle+uEhLaaDGNG+00AnUDraMvHNRq83WUFdNdqW4b/8j99kFLw/9dYEdAa8x6O0 fo2eoCF5q9d9JTgSyYVSd1n2ZaHOZlfrM9YK2cxvpuBG1bc2f2gWet0OmvLcf7+7QUvoav bSpySAUfrJJ+j/Gkzhj6GVa5nJDIMu+XD1tx5pxkjnURv5THhz0WjfLSHCwe4O7xzkzAJN kOaJ/wtjdcqaVHQIEE24tAKEaFGGMSMReR2FCgrk/Xh6C/2yRC4bUuusPEWIgw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713644841; a=rsa-sha256; cv=none; b=A2przwH/5IuoEhK9XambOzk7zRyLU8/A+pDwBVfH/6NdhG//JoWc2VcizrclnjGgA52p4s rnZI4xVgM3AhRaTBULpv1yeqkA972HK2tGHDPtXTqV9mhgPCRaQgAot695G0w/oUwj8y5w pzIGriMRtX3uzrR/AZdkNK5iPNNIho57aTnr1XGp6QkFNe82PS/q5I1WLyuMNqw/O7856g /9EXKTDt0ffDXVdugaIy+JFlsWCSpn8wwteO8R6jkbVFW7EcB6DaljrgzhA+rz+br14JC/ RsjFONcGpvq1WXHfrKK/ziab3yi8FXBZA/vc80qJteX3Yj6KcfSN9qHHE7G1KA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713644841; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z15hNCrvowrbn/xo6jCsjvug4opdus56vAAK9Sv7un0=; b=EDcl6ytQSurZ3kSkGH6SWcZAKqCJtb5sgal6It8hqQXxDjHy4lJPSBdLjjqdT+4N5zXyil +qiyFHIVlZelJ6Sx73EAMAcF01mqkOVhY+1hetMxSFOrhYo9twMpOWVhMsBqml4jUeUR19 49uwo28AXO5go0fvDIdmHWDKzJqFhjpNYR8irL3AtUnioIZGAIlXOsYbucHx1EkN0agaGs AR2Ui3ujgVt41qy8YyfWHYbeCEdD3HoQCNCRkbZC9OBPNXsCxRhEooR14sc8ygC3NwXUTU dDywsuadsUyZ6Oyg7qMa5Dc602kD53ftLCIeWZlrdOone7zL55u/2NFAvv2uQw== Received: from [IPV6:2601:644:937f:4c50:ace4:f593:f45d:460] (unknown [IPv6:2601:644:937f:4c50:ace4:f593:f45d:460]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VMNNS721MzDy8; Sat, 20 Apr 2024 20:27:20 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <9301b16a-06c5-4f4d-b706-257936a1e18d@FreeBSD.org> Date: Sat, 20 Apr 2024 13:27:19 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Remove some alloca uses Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20240417225228.1789947-1-tom@tromey.com> From: John Baldwin In-Reply-To: <20240417225228.1789947-1-tom@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/17/24 3:52 PM, Tom Tromey wrote: > A few spots (mostly in the parsers) use alloca to ensure that a string > is terminated before passing it to a printf-like function (mostly > 'error'). However, this isn't needed as the "%.*s" format can be used > instead. > > This patch makes this change. > > In one spot the alloca is dead code and is simply removed. Approved-By: John Baldwin -- John Baldwin