From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <patrick@monnerat.net>
Received: from jupiter.monnerat.net (jupiter.monnerat.net [46.226.111.226])
 by sourceware.org (Postfix) with ESMTPS id AA9533858C2C
 for <gdb-patches@sourceware.org>; Mon, 23 Aug 2021 17:37:05 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AA9533858C2C
Received: from patrick.monnerat
 (56.82.193.178.dynamic.wline.res.cust.swisscom.ch [178.193.82.56])
 by jupiter.monnerat.net (8.14.8/8.14.8) with ESMTP id 17NHal0C004484
 (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256 verify=OK);
 Mon, 23 Aug 2021 19:36:53 +0200
DKIM-Filter: OpenDKIM Filter v2.10.3 jupiter.monnerat.net 17NHal0C004484
Subject: Re: [PATCH] Replace deprecated_target_wait_hook by an observer
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
References: <20210822164256.144875-1-patrick@monnerat.net>
 <a6813d36-e495-a810-e545-8ff8a4774a08@polymtl.ca>
From: Patrick Monnerat <patrick@monnerat.net>
Message-ID: <934649d9-1f4a-0b3c-a6de-5641c49bb0c6@monnerat.net>
Date: Mon, 23 Aug 2021 19:36:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <a6813d36-e495-a810-e545-8ff8a4774a08@polymtl.ca>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, BODY_8BITS,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, JMQ_SPF_NEUTRAL,
 NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Aug 2021 17:37:16 -0000


On 8/23/21 6:26 PM, Simon Marchi wrote:
> Can you show to the
> corresponding change in Insight?  I'm curious to see how Insight uses
> this.
>
Hi Simon,

Sure! Here is the important part of the Insight diff:

-----

--- a/gdbtk/generic/gdbtk-hooks.c
+++ b/gdbtk/generic/gdbtk-hooks.c

@@ -685,16 +685,19 @@ gdbtk_post_add_symbol (void)
  /* This hook function is called whenever we want to wait for the
     target.  */

-static ptid_t
-gdbtk_wait (ptid_t ptid, struct target_waitstatus *ourstatus, void 
*options)
+static void
+gdbtk_waiting_for_target (bool enter, ptid_t ptid)
  {
-  gdbtk_force_detach = 0;
-  gdbtk_start_timer ();
-  ptid = target_wait (ptid, ourstatus, *(target_wait_flags *) options);
-  gdbtk_stop_timer ();
-  gdbtk_ptid = ptid;
-
-  return ptid;
+  if (enter)
+    {
+      gdbtk_force_detach = 0;
+      gdbtk_start_timer ();
+    }
+  else
+    {
+      gdbtk_stop_timer ();
+      gdbtk_ptid = ptid;
+    }
  }

  /*
-----

For more details, see Insight commit 
https://sourceware.org/git/?p=insight.git;a=commit;h=16042bf


Patrick