From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Check index in type::field
Date: Mon, 18 Oct 2021 15:46:11 -0400 [thread overview]
Message-ID: <9380d9b3-4f2d-9584-7658-e75ace0d8858@simark.ca> (raw)
In-Reply-To: <20211018193526.175222-1-tromey@adacore.com>
On 2021-10-18 3:35 p.m., Tom Tromey via Gdb-patches wrote:
> This changes gdb to check the index that is passed to type::field.
> This caught one bug in the Ada code when running the test suite
> (actually I found the bug first, then realized that the check would
> have helped), so this patch fixes that as well.
>
> Regression tested on x86-64 Fedora 34.
I think that's a good idea, this LGTM.
Simon
next prev parent reply other threads:[~2021-10-18 19:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 19:35 Tom Tromey
2021-10-18 19:46 ` Simon Marchi [this message]
2021-10-19 19:43 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9380d9b3-4f2d-9584-7658-e75ace0d8858@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).