From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112630 invoked by alias); 31 Jul 2017 19:21:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112607 invoked by uid 89); 31 Jul 2017 19:21:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2848, Hx-spam-relays-external:!192.168.0.102!, H*RU:!192.168.0.102!, H*r:ip*192.168.0.102 X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 31 Jul 2017 19:21:02 +0000 Received: from ESESSHC005.ericsson.se (Unknown_Domain [153.88.183.33]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 6C.86.07915.B138F795; Mon, 31 Jul 2017 21:20:59 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.33) with Microsoft SMTP Server (TLS) id 14.3.352.0; Mon, 31 Jul 2017 21:20:59 +0200 Received: from [192.168.0.102] (80.216.43.226) by DB4PR07MB313.eurprd07.prod.outlook.com (2a01:111:e400:982f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1304.10; Mon, 31 Jul 2017 19:20:57 +0000 Subject: Re: [RFA v2 10/24] Remove make_cleanup_restore_current_language To: Tom Tromey , , Pedro Alves References: <20170725172107.9799-1-tom@tromey.com> <20170725172107.9799-11-tom@tromey.com> From: Simon Marchi Message-ID: <94022dcf-0cdb-f271-9b8c-66682ac41b1c@ericsson.com> Date: Mon, 31 Jul 2017 19:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170725172107.9799-11-tom@tromey.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: HE1P190CA0046.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:52::35) To DB4PR07MB313.eurprd07.prod.outlook.com (2a01:111:e400:982f::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a12a7be0-5bb6-439a-01f2-08d4d84945bb X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DB4PR07MB313; X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB313;3:2uECVGW3c1Rpzrq7xmZew/b8AcrtrBqzaQS8xaQSTtTfsFbIEk6ysBuSRW4MaBOBr+bGMyTdy1uXMYmJ3wihF2ekZNmSWhvo3SMpQkm8WBw20/4ixKiCx8I5rDstZnocruKsXbJUARR+rce9KYRfFX0ufRdckx3eiMkUY1f93epp6BFFRgT09ZHfPjxG5VjI+5PPuN/bH+AmLyTgsg2iUv8MHwv4gUMvVwRCpa84hDlP7RibCt3u61X3s+QGGdVKYRF5ZTgjuFSc0MjZhDzSJcHPorxp2cwArJlyna/ztupU8kJAywUFypkI3WGNTCCYzawxjDuhUIrzegYtqFx948ER12yFkf/wtLrIx2PBPDY2RXagY/daNjlx7n2Jet+zb2aGQ/NL6kIjZBrz7g1bHDPQO0XOMtRAILPDH+3fZ2eNdKTVnuDPaDNLqLT1JZO2obOI+pF0aydxp3eEcGzKS+iZDVp0rHzPQ+R36nY5psteIoh7VrCUNw6JfGGFDO1Auf3ARPhZaToZmN9eyv4g9ZIGnJ6kmzfbOuTpzflsS9CRTw/HBuziFXZLlZDWo892FdrapcVbAOcoza6KcEJeVZjgsdYPpKeD0VIU1pGxgIKAy55C3yMMi9dC2lHyryV8yr4zrEIBMnYfOeFyBxPNWbMsA5WzYvZU9WnZxu/UxQnXp3WFxZzwNQkOkUyUmJCko1DMjltwudgf+Vf0gdHdDVdNF8si7+NMDX56rWOfSIK5j7x9M9JneC9w8tWbCRyZsFptXptXmY2aaRuGnctv8jBC87xs7KOR/L14U83d7kmzS1PTI285s2rH/9qU5R0I X-MS-TrafficTypeDiagnostic: DB4PR07MB313: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjRQUjA3TUIzMTM7MjU6Y0pLMWJ5MmxpbkRUMjIxUXdXR3JkUHpPcFBa?= =?utf-8?B?bnoyTHhjeTJnMUQzeDBhaVhKOTl2WnpHMGJlZVU0aE9rODR1NFM3SGJ5WXBx?= =?utf-8?B?Rlg4ZWk1ZUFVVGJLSmRWVlVybWx5bjhxWU1KUHp6ZG1aUWJPbXZRL0tRWUFD?= =?utf-8?B?RTYxTCtXUXBlcmljeWc1Y2V0VXQ2WGFHZnpRaHRVQ1g3TEUxSThuYmhNUGVX?= =?utf-8?B?UHVQUEZ4U1lKbGU0aTN1UG9VOHIyd2ttRXVPNmhYakgxcUlWVmt2Skk2cExh?= =?utf-8?B?SlhRS245d29Vd3pJVERsV1JvejFBVVNHYWd2RG5Oakw4NnhicVoxY2QvTXky?= =?utf-8?B?cURWWUt5WEVvc0F6OGovSFBHci8ydDZ5dHNrbThidkdxdGZEaFFUQk96THVX?= =?utf-8?B?R0JOWGNwNHIyVWV3eld2RHlzZDNCSGs4NW9RSDE5TmdQWEFhWlhTMjhseW81?= =?utf-8?B?RGZEWFNzZWdFTlhBODdrVVR0SWtKZFoyWUVDb1lHbUE4MDlpVVpYc3ZFeXFH?= =?utf-8?B?RUZ1V08yMnlvRUhSOE9xYkRGNktzaElKRExpRXVDODJxUFV1YmRRNHN2bC9h?= =?utf-8?B?QUZZMWlNNzQ2Z2F4ODVrQjB5OC9ZZ1BLUWdqcFFqOE52QmJueHg1RXNLVytD?= =?utf-8?B?cUxPNTcwcXY5bVlwWVducUx6eENselBjRXhFTnpxOXE3RU1HeExsM2RGbzJj?= =?utf-8?B?MlhUZkxnbnFWdHRtQXI4ZjU5ME9GT1RlTnVGNXY3c2ozUEF6cVZDZFh1bXYx?= =?utf-8?B?RFVDY2VldUc3NWU0TTZiKzk5dXgvY29oWWMvbXJXLzRIdnpjY0c5TEYzeno1?= =?utf-8?B?a3pzUlA3eGkrck1FZ3Nub3dwa21SU2UxWk81ZE54ak5ndHpzMVh4elZwWjQr?= =?utf-8?B?SlUvbXVZdW53aVdmbVZlYnRiT1RYcEQ3cHIrVzllbXBnSjZXWkx1Z1Z2ZGhR?= =?utf-8?B?bjRJVzRBQlJOYW9jNW4rRFJxcmMxQk9kRHlYZUJhdFlnWXB5MGZCUG9GMGpr?= =?utf-8?B?S0dobkQ1Vjg3THdtekJoN3ovVmNVS3k3clhpVmlxK0tGR0Q2a2dVZWdYQy82?= =?utf-8?B?VE5ZUDltN0ZTMzlhb2t0TXA0dXpjeVBxbllKckFSQzBTc2FrZHVINmJDYjlZ?= =?utf-8?B?N3R2RVc5Vm5aQmVLQ01VTUNvM3VzWVdtRDVRZUdtcFdJaHBTOGRGckJENDN0?= =?utf-8?B?cHhhdHQwbjdVckVUTllxc0xUUnFpUTZNYW5NT0ZTWnI1ZmFWZDh2Ni9iR3lO?= =?utf-8?B?ekFzNzVnQVhkaDl2SzUxLzhMcmFoNXFVZ2JQSjhWVTVSMjcvVDRMV2IrNk5U?= =?utf-8?B?dkU5RnZ4WmlUQT09?= X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB313;31:NJt9fJjR5d4TYQuUbWODoqC1lNo8LF1+a9HcMn/BDwl8oNS9qCqYLB2Yhk4+szwPCgBWZpsjuHFWJANYwZu0grQdW99qZcX6DlS4di0UBGMtdnY1tobt15b6FHZQkF73M+fn2uz/5pK1e+210Isqnm+mzr/6lBi86qJWC2rVdaj0urCydXVIuDibWPHWwnxh943J9TYAujU8VHYeDPzA8ujjwid0kBNLAiMMokpo8PGfLgCf/L9mJn4/usclEuhWEcW4sDj6X9slvk5JHsbeSKVdMTr2CbPCqMt00f5n7sD6XeF797a3amplaehWbduOyelwzufNyRndsURZGHPOgALV4TpB5FNH/eqE0DleBYBBY3qCro5BudggEI591J0suZzHMiHkbESYAaXrWUpTa2jKleSumO31vRnw4bicgHtXgnB/6B4XJGvqsaIC+c5JeS9oGEDelGXAY9J19F0JUtCWXuRO02BYXodWXFHg/cDK0dW3r/rYOVJK+JlQOMcUSwy0KAAOzqvJUbmkLSOUmuDNgW5FfKiPzV30OrI9VhPhogZx9a4GLFCVMi+1r1YXtXtgDN9Bz8BMSxTxAQ7uCd9g11AimH8VDD65BoVVkOttmJKYsiyQUA+zHtsMbl/1LEw0qcElf2n7PSILOrTC6QGDFH4VWMHkXY4nf4PicwmLgQ9iYC6gIyucvuve4SM0 X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB313;20:hfYUP8xvo42B45H9EA5QtB0rnAGLauZKiS2Cd3Behl6pjy4Dyl2pvfliW/kX3ZudlCzCLfX7rf9B2yPlsfcFxava7rtFqit6bL/nOWQ6nD1l//QJ3SeSPeTXGtiRaVyleystnF3Pq7Wxq7QdcDRQLa5V81Ru5FatTxSQ6OsW1nPkatvZjUXMOVkCceDDfouSwnjyDRstfr0jFa+lz3SKabKwhx40oW7FrmOxBF1Mw88DjMoh8beiep68diSDEl3FKhHttrDL6uglkmuXFzgyPu0D+LIiLxK5vQxiEhaDgRk5yQFjVkbV9sE2+jxq1/SgmZO9+2YOblpldnH2qUZbPjK/eLijb4FPgymFlupnShUashS4KzIFGv1tqUk8Znp00IkAMqO/lQ54UJrLos6j5C6funFMvNt2Ba2koCLNl0u1ZCA/CK7uEjGU2ZUZpXH40TkaDZWGvLqr+5BAR/LZ+VNmqMB1pEu2gZGq5WfkoRlwCJ4PVXHxoKDFiinfRNx3 X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(6041248)(20161123562025)(20161123558100)(20161123555025)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DB4PR07MB313;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DB4PR07MB313; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjRQUjA3TUIzMTM7NDo5OE4vaS9IK1d1Y2xFY0NPWWpvZjh4a0F4cVdu?= =?utf-8?B?V0VxVFVNSXdKNWErVVVmOE5nMi9lRHlZZndsSGgySkJ2ZGtReU1jUXRtU1Za?= =?utf-8?B?R2FOdk5KelVacmpFVDY0eXl5SmNKb0VWRDhFQS9pcU05WG96MHZOQjlhcGpS?= =?utf-8?B?TElWbUs5WWtyK1RKVGlsRmI5WkJxc2hVQXQyTDZVUFA2OTJSemVBZkdOb1F1?= =?utf-8?B?YkVIcnZXWEtSUlFIZmdPSmxRS3NGT0s0UkN0bmR3SmVyZ3hIZWNRSFJQcW1E?= =?utf-8?B?REs5RTA5VFBUQ2xPaFBML1duYlhBdjJzUTE2YXZHaWM0RXYyOWtFdHJzVnJD?= =?utf-8?B?WFlDcXM5aVJRWmdBblZLYlZSKzVzVlByUGtPbTRna1NxZnRyUUlJYms0OEs5?= =?utf-8?B?TzA1ZmJPTFpFcWdIUzFxamRJemdSa2FFeDhnemZxVHVvRDBKQ3lSN2pNNkd1?= =?utf-8?B?Yk51RmdqVi8rRGhSSVp0THFrVXkwdEl5ck9SdHVzSmlVT3ovUU9BaGUvUGtD?= =?utf-8?B?c0FqV0hZMG1IT29aVG81OTlxeVZXakR0SW04Q3dzMzZ3M3dGaEFhazVvTW9K?= =?utf-8?B?cGNLejYxSlZtZ0hLVWNOeDRUaHJkNDBpNUxpbU5FUmdFVVhkcmFIbVgwZ1lK?= =?utf-8?B?UC9rNTdBSjVLZDZuc0Y4a1Z6dXliZmhyaGZDU3RuS0hKSHlTeDlXVHhTdVdQ?= =?utf-8?B?MXkxNllIeUx1YjFMbXFJWjl2ZG1kQXhXQndxdFhpMVlwaWdWNGpPUHVha2Jv?= =?utf-8?B?TmVaVFlLcVFzRVZJSXk3UTN6dFV0QXVJT0dCT2VFZGxIWGdXQlV6dEpzZ3J3?= =?utf-8?B?Wnk5eEZONFFnRENBTUlJSDI1RnI1UHZ6TW9sMWUwa2FyQzZRejNkZDhRVVVt?= =?utf-8?B?YklVZkdlRlg3VWZrajFpaE11VkF3RWcrc2FOZ2tha2ZlUm14MUFCaVpPc256?= =?utf-8?B?dmdlNXZlNHIvbHZPcERkeVZUNmtyUXJQZUUwVzZzNDFEL1h2TmVES1VrL1pC?= =?utf-8?B?Tm9ySTNTTDVzeW96c3RsdHg0ZU9OeUIvMWl4ejV1dEQ1Q0h0c2xybFZpZmlr?= =?utf-8?B?anZiaUJVNks0RndoMERhTjNrSzdLZzMxZnQ4VE12VG1VTHhSOHdDRWhNMTds?= =?utf-8?B?S1FPMThkUEprR3JPQkZDSUpiZ0ZZU05uZEkveWZ4cUYwNEJGbkNidXE1TUpp?= =?utf-8?B?U1NTYVFONjhKSTUycWVJczBDNzAwVVNZWjlwMW1JL3FRbEgwc200U3lGWU1D?= =?utf-8?B?WjBSYXZoL3RBaGJtdkppL2QwUW9ydVRsL3VFZCtPYXN3WmdVbkM5VEFzcW5G?= =?utf-8?B?TjVZK04zbUlSMVdsL3J1VWZXTG9vd0x1SC9VZGdnVzBBblA4RURDaVhlZFU4?= =?utf-8?B?S1JDd0E4ei9HYkYvdnp1ZCtPeXFjRnZld1l1MTEvWGsrcElCcXpVdmI1bUJK?= =?utf-8?B?RXZxekEyaktWTEtEOVIxWEIrL20rdHI2dWlwZGVDN3JLL2tMOXhKSC9zc0pz?= =?utf-8?Q?MfhvyYfSkM9GgNSpB1R4sNB8I3YRwkNLYDUXO0h402Ic?= X-Forefront-PRVS: 03853D523D X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(7370300001)(4630300001)(6009001)(6049001)(39850400002)(39410400002)(39400400002)(39450400003)(39860400002)(39840400002)(377454003)(189002)(54534003)(24454002)(377424004)(199003)(64126003)(31686004)(47776003)(65956001)(65806001)(6486002)(77096006)(66066001)(6116002)(3846002)(23676002)(189998001)(97736004)(31696002)(2950100002)(229853002)(230700001)(106356001)(81166006)(81156014)(5660300001)(7350300001)(38730400002)(6246003)(478600001)(8676002)(42186005)(65826007)(33646002)(6666003)(105586002)(86362001)(36756003)(117156002)(53936002)(50466002)(83506001)(53546010)(4001350100001)(101416001)(305945005)(25786009)(68736007)(7736002)(54356999)(76176999)(50986999)(2906002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB4PR07MB313;H:[192.168.0.102];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjRQUjA3TUIzMTM7MjM6WXMvclJUSjdML1pHTmFJVXNob3JQWHN0R1Bu?= =?utf-8?B?VTRVeGZzdHRaRGZ3UFFYQzlXeWhnYWJyWXNHUldJbWFCLzlaMThjUndnYWda?= =?utf-8?B?dWF3dHRubVdXSzcyVlhFbVU5ZkpFenBESlRVQVRDWmJVMUt5YXJPSFFvc20x?= =?utf-8?B?YnhEZ211U1RBVSt2bjdyempmT2cxa0M4QmErV1o1Znd4ek1McStJS2pUL3FY?= =?utf-8?B?UGdob0R0ZWFieitZYXdhdmc1RFk0SW9FMThMUFlORG9aRk5EOGhKUWhpcFo3?= =?utf-8?B?aGdMZUpZcFUxREhQcURndnRpc0M5QXFKSkNsa0JZaVNvNGgxcmxwS2Q4dWxt?= =?utf-8?B?ejZlNXlvcmVqakNZMm5CclhETHlNWHZoaWU1bVpwdUR5cGx3Y3poeGVaRWda?= =?utf-8?B?bVQrOVBoQnZpNmsxUjQwVUtlZkc1S2szZllZMVlYSHFDTFNQUGxNZ3prRCtt?= =?utf-8?B?bGNJTk5ES3d0RVZnVjE0WkVxeWpjS24ycW5mTTJGVS85dlBZTForVCt2Vlcx?= =?utf-8?B?U3lJM2hhbnlXbUwrNVU4Skt3d25Kbmc2dUhraUJXUzU3VzdobUI4SGZmblQ1?= =?utf-8?B?Y0tscExvTTQ4cW9BKzFWeEk0M2FWQ3B6QW1yRG1MOURjQjdpMWNDczNxd1ZO?= =?utf-8?B?aG01Rzg4cDJIdkRYdElMVEpKU2I5R0hWNnB3ZnJJQXRob0xZSHYzdE95UWQ3?= =?utf-8?B?eTNGaDdVRWI5OFB5RGRweXJFN1BFUmc2VHhoUngvUndnaWdwaTUwU2tsSkpQ?= =?utf-8?B?T3E5UHZRdGQrUnFmU2FIOVdFakwzK3JPR0VxZ0tGemxiU1gxL2dnN1VCT2dN?= =?utf-8?B?THJvQm5kdDJtamVzWHA5b296ZXBtTUQzUnNKSnV1eFMxdThoajRiQVhPNFZk?= =?utf-8?B?dVhGSytZTXI5S0owVXhsTnVTRlpNMFdMT1BYeFlWV2pJSHBHQWVTVU9kdW05?= =?utf-8?B?U25kK05Vb3pFODlnRGV3N2hmOHhNYVB1MkI2RExwQ0VidWZDMG5nWjQ0M3Ft?= =?utf-8?B?a0dlUTM1SWdwUTJqRFdLa2FDSHRZNjZ2cWdEeXJGdWxWTnE0aXdiVmRScWhx?= =?utf-8?B?ZEpUTWxMZEtWRTVONnNaelZrZWI4ZTR5RVZIVEFtdmM5dmlZbE5URTRkTlpo?= =?utf-8?B?bks4akhGREQxY0Y5cmZzZjhocTNMNTU0am92eWtTNUVyWC9WdlJvTURZWkFT?= =?utf-8?B?VitEVzFDVXozZWpJNU1hTHY4R045OWEwOVpsYUxhWFUxWVRMc21RQTAxelha?= =?utf-8?B?ZkJvQVB3b1liRlRGb1JZbDFEYXhBUExlTVhVdVY5R2tDZ05rNzB1dVV6VFpn?= =?utf-8?B?TzhFc2pYYTM3clhvL01OU2pTcDZaekFORDZHc3RwSzBBdUZvV0FSR1VNRDVt?= =?utf-8?B?OFFqUisxRHRNVGd1cDB6TWdGN29sRWJKdXRyVE9HKzEzQnd5cUozRjhhdHlD?= =?utf-8?B?cGVpNHRjZlpXZ0VwYlYxSENWbjl2d0ZTNldnREpSTC8xQjFrTlNQeFhZYzBn?= =?utf-8?B?OEJaQ2JYQ2RMUjdmWEQzUVU3Qk9ZaVl1Z000WVpFMjdNaE4ybC9Ua0doVThF?= =?utf-8?B?VGdNRVNEeFZmQW5iS1hQR3c0QXEyOTdTejNZOE9ZZHVwZ29MMnM4Zk9oTnhp?= =?utf-8?B?V1U3YXc1c0JNbDR6RmF4Z2RkSU9QeVJkb1NINmdzTVp1UlRoZWgybjRyeXhr?= =?utf-8?B?VC9Fb0FsaVowU0hZVStPdVJnNHVRM2hNUzdDSmRZVWJyNXUvbjA5MXRrVmhS?= =?utf-8?B?azRwaTFkeUxyTXBVL1RvZGJoci8zRUREUHIxaUFpSFdZbmhEazVZTnUxdk9C?= =?utf-8?B?eUp3OXRNVlFvSVViaERVd0FXZmxnZEt5eWZTazM0cjdQS2l0OU1nb05qQ1du?= =?utf-8?B?dllFRkp1WE5JdzZ4eVJyWUdpZEpHNDZYQkFEMUE4Z0hOSUl3Y0RiWWdmMkJj?= =?utf-8?B?d2FTWi9lenU0NWxGdDhYNGoxYVVZMkcyVWpjR0c3UHVweGYrVVFqS3RZOWNz?= =?utf-8?B?emZQRkRkK2V5LzFZeTZnTHZRRFZma0R5VURWdXcyL003Wk56R0tsQ0JFMVRC?= =?utf-8?B?K25yR1dQL1ErNU1PS0JxUG5pdEVtb2tGUlR6OExDM0VKdHgwN1JONnpHZjF0?= =?utf-8?Q?OcJb7JSgmAwd1KI9ST2caA=3D?= X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjRQUjA3TUIzMTM7NjpKdE0zdGZqN1d4aHZNdmpIVEhuNG56VjNVRzE2?= =?utf-8?B?aHlBMzlBVmRFaHAvZ3RHM3VoNUw3di9jVkM0QzR5RVJXeWwrUmZWR1FjQmEv?= =?utf-8?B?Zms2ZWMxc2pmbHpRbm93YTZ4TUNtZE41Y2QyZmQxRWZTR2w1WWFibmJGN3Ur?= =?utf-8?B?VjRPQWJOUERydUMzbHErQmtremVjSUFXUDEwMFNBZGZKUlBQd1VseVo3c0dn?= =?utf-8?B?MVljVVUvZGpCRk1mbGJReFFZMXNOQnd5V1Y2QnAyY3gvRU1nQUp3L2wvNWlm?= =?utf-8?B?cWlKcWE1bmRod2dtNnhzdHNkbEhBeDR5RFZHZXM3bC9vUy8wdTlET1hLcHJw?= =?utf-8?B?bjlwakJkb1BaVDFVR3g0MlVtTnpDM01jaTNHTGluWWZsQVZ6SVJRR0V0VHcv?= =?utf-8?B?dzNKUXJ0cUkrbFQvUXJXcmpmSm1ndkpMSlhVcURwcU1qdzRUajBxaUtSUXFr?= =?utf-8?B?TnNGWG5MemY1TWIrdG1Wa2R4eDEzL2E2aTFvVmM0Z1Z0ZVVXYW0wVkxTK3Fx?= =?utf-8?B?c1BPV1NobWh6WHFPaTNVUkd4K0kvd3pjNnlzUmh5ZXp3cTJid3RxTVQyU0xw?= =?utf-8?B?RlhFcDlGamVJbGEwYmc4ZzM0VUNEQ1JNQW4zTDNXeG13eHU3bzV6Umg2U21N?= =?utf-8?B?NmREZUYybGh1STRFTmVBSi9mZGQ1UWlUL1V3RXhRUjEyMWphUXZhZW9Odmlp?= =?utf-8?B?TDYwWFY0aWZLd1FRdmUreTJwWldhSUNCaHJIK0EySkNJakFiSGwwcjlmZnhV?= =?utf-8?B?ck1jNDlrcmE5amNFQkVKamlQUmc2MzBWRy92WGdCN2hHbGZHTXZWN2lvZXJB?= =?utf-8?B?dVlQYWdXMndyT3cwbnNsUC9HMCswOU9SVGxoRDl3cjFkdzRlVFFCNTJqblZ5?= =?utf-8?B?cDRYMU5HSjB3UG0rQ2svTmVDQTdTbUdiQzhuV3dlZDFrdkRNOTBqK1pkekVW?= =?utf-8?B?d3B3cnFiK25GUTJwRzlHblJRRHhDaEc5cmovdFdkWHJKcnRYQmw0dnpBTmpB?= =?utf-8?B?NmhNWWNDVTVhZi9WMDBLNVlHOTNFV040YXpVZGlYaGJ3SXdlbFROa3BlZGJ1?= =?utf-8?B?cEttSDNkeTlGL1dtZlBqTW4xREJBMHExRDJ0VllJelRLREEwZG12bm13a2o4?= =?utf-8?B?N3VXY1BhbWphbFZMSHVncnNpTWs5K0xnV0ZpSUNXNEF3aUtLSlg5WUsweCtk?= =?utf-8?B?WGNIUTdxYlQwMnNZZXI0L1VOUjZoWGZUc0RDKzdab1B2cUdJNC9kTzVmdlNa?= =?utf-8?B?Z2JZSXBJTGlQaDdzekdHUzJzazFtT2thZjgrcXZ3N3RUTkhneHhEN3VSOXdG?= =?utf-8?Q?E/pMQQJnPTh/iHSmm0vMQ7eVCvnA1Y=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB313;5:OT82RdNk/HnYuNw15LD8KUpuRXIDH16xPFKkNReeAeaMv/ot8jBrbN2MiIRyDFUaoi4YrDksG5ibw/HMlC0epb9yd66sW5dfUxpVxzimOVs8l1/ncUulrm7EYV+ClHFRwd1e6hBuRwQSa67snhxYH71JSC0HqLTC0Mfjkgwd+WOg/Re3YN/Xk/svEyLJfXLLjiBSfRiROBTL6XxO3pHseHvkYvM9kTHlldE/BtMPcGPL8KJGvqu0MjvP1eHoNS1e05ZQxXObwKiv8JTtjjlBvRtNmA+a2V4rZtGsZzg+EhS9zwyYsyvC+5jbCZoE64j29CzSlbKVgE13j6RY1ni74wdiZa+pUg3xyIIaNsP4eR+or680At0+gqM9kxg5avTpluu5dewT1ZXRAEf5G/xHTLV1t5JfSGfSmE8t+mzfXHlK4HQK+swionGKI8Q5faIY5gVleu+I7Vzx2x6IqtWC63CM2++L8RgyH9X71bk/lE83a5ONtlzH+3JdsQ95CZQ/;24:GpoyV5tc10BJhCIO2xTklg2cK2yOvXHoA86+4ljjQxAD+R1iQF1t3mgCBgFqG8JwZJXLyQkcSADuWutALbGPtDbWK/Zj91gzKonud9nKnlk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB313;7:2UbWmBAPvjM2tmam2FouUeywHB/s+LAkZBg8nit5bRRcg6Isgb3dB3RLXq2eGRiIy52AeklbRqASTlyJnv72uEnZD5tbI4Bun0xn/RZD+WVywofSwFgcIQKUewQcTTaQHEWPXtQ2iRq4rct/LolvyckzwxWeZ5WDhJy3MeRZO7PW/tRbc7pEEUj7K6rcuGgaFN+hLd8rMSWtGbNMJPGOeeNcr0JoseSCQHx2AXd6TZwGDPuYeQTtTxRcven+c0JMiWRMD7LqQ4NwsP4CYlpSkV/S/qdDKODMqOCO6fxQghnB2DaI0JxBgFyU1XXtwVkh0BaM93aWCtxaMTjXhL1pt3a1XEtmj4IgZlYaQTSJVNSTjoTcH0qhPZBLkBoSdEdOxfrZH6yj1zKRbAiGVK9rKYtMqn82p8NSwra9p/qh9J7erFrNczx5rtsrmZkUGEW2/Iy6znEsUF3PBQOcHU4VCeOR+B7jSHNqif+jJJ22ALbsqQMGFLiWkAcevUB3j/rOiUZsBgz0lDiyDLz3ri0+wDbmzE7jNrblrmpJB6VTZ51501WqyUZ1lbVF3pU78IPh3zMo0BuQXp0commqZc06tQkcSxKPsHg99fOQHfgojfPsiglL8f1aqUCITPLyUf1c/8/us7dfKUFyLTLWSJEoE63D4ywvrYoCvyuSHI/Z14lF89dzC9BkotZgqiLCSu8vR/qjX2IH+olix8v2/QyduvThbeKm32s7ttHc8ENOiQTQi8ZGCleNK/YSu6P5t8Wo50nv7u7aLl+/AsFJvbh+SA3dC+oczGjA5zgBHssbSKQ= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2017 19:20:57.6115 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR07MB313 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00453.txt.bz2 Hi Tom, On 2017-07-25 07:20 PM, Tom Tromey wrote: > This patch replaces make_cleanup_restore_current_language with an RAII > class that saves the current language, and restores it when the object > is destroyed. > > ChangeLog > 2017-07-25 Tom Tromey > > * utils.h (make_cleanup_restore_current_language): Remove. > * utils.c (do_restore_current_language) > (make_cleanup_restore_current_language): Remove. > * parse.c (parse_exp_in_context_1) > (parse_expression_with_language): Use scoped_restore_language. > * mi/mi-main.c (mi_cmd_execute): Use scoped_restore_language. > * language.h (scoped_restore_language): New class. > --- > gdb/ChangeLog | 10 ++++++++++ > gdb/language.h | 26 ++++++++++++++++++++++++++ > gdb/mi/mi-main.c | 6 ++---- > gdb/parse.c | 22 +++++++--------------- > gdb/utils.c | 22 ---------------------- > gdb/utils.h | 2 -- > 6 files changed, 45 insertions(+), 43 deletions(-) > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index 871b1f0..37971ec 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,5 +1,15 @@ > 2017-07-25 Tom Tromey > > + * utils.h (make_cleanup_restore_current_language): Remove. > + * utils.c (do_restore_current_language) > + (make_cleanup_restore_current_language): Remove. > + * parse.c (parse_exp_in_context_1) > + (parse_expression_with_language): Use scoped_restore_language. > + * mi/mi-main.c (mi_cmd_execute): Use scoped_restore_language. > + * language.h (scoped_restore_language): New class. > + > +2017-07-25 Tom Tromey > + > * source.c (get_filename_and_charpos, forward_search_command) > (reverse_search_command): Use fd_closer. > * procfs.c (load_syscalls, proc_get_LDT_entry) > diff --git a/gdb/language.h b/gdb/language.h > index f4852c1..3586526 100644 > --- a/gdb/language.h > +++ b/gdb/language.h > @@ -633,4 +633,30 @@ extern const struct language_defn opencl_language_defn; > extern const struct language_defn pascal_language_defn; > extern const struct language_defn rust_language_defn; > > +/* Save the current language and restore it upon destruction. */ > + > +class scoped_restore_language > +{ > +public: > + > + explicit scoped_restore_language (enum language new_lang) > + : m_lang (current_language->la_language) > + { > + set_language (new_lang); > + } To follow the nomenclature and behavior of other scoped_restore_* , I think this: 1. should be named scoped_restore_current_language 2. should only only save and restore the current language, and not set the new language. About #2, I think it's clearer to have: scoped_restore_current_language (); set_language (some_language); than scope_restore_current_language (some_language); The 2nd leads me to think that the current language will be restored to some_language. Thanks, Simon