[PATCH] Enable hardware breakpoints for gdbserver on Windows

[PATCH] Enable hardware breakpoints for gdbserver on Windows

[Hannes Domani]

When trying to use hardware breakpoints with gdbserver you get this error:

(gdb) hbreak main
Hardware assisted breakpoint 2 at 0x40162d: file gdb-9493.c, line 5.
(gdb) c
Continuing.
Warning:
Cannot insert hardware breakpoint 2.
Could not insert hardware breakpoints:
You may have requested too many hardware breakpoints/watchpoints.

It turns out the respective types just needed to be added to the
appropriate callback functions, because x86_dr_(insert|remove)_watchpoint
already handles them.

gdbserver/ChangeLog:

2020-05-11  Hannes Domani  <ssbssa@yahoo.de>

	* win32-i386-low.cc (i386_supports_z_point_type): Handle
	Z_PACKET_HW_BP z_type.
	(i386_insert_point): Handle raw_bkpt_type type.
	(i386_remove_point): Likewise.
---
 gdbserver/win32-i386-low.cc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gdbserver/win32-i386-low.cc b/gdbserver/win32-i386-low.cc
index 389ec49284..410f10a7c2 100644
--- a/gdbserver/win32-i386-low.cc
+++ b/gdbserver/win32-i386-low.cc
@@ -162,6 +162,7 @@ i386_supports_z_point_type (char z_type)
 {
   switch (z_type)
     {
+    case Z_PACKET_HW_BP:
     case Z_PACKET_WRITE_WP:
     case Z_PACKET_ACCESS_WP:
       return 1;
@@ -176,6 +177,7 @@ i386_insert_point (enum raw_bkpt_type type, CORE_ADDR addr,
 {
   switch (type)
     {
+    case raw_bkpt_type_hw:
     case raw_bkpt_type_write_wp:
     case raw_bkpt_type_access_wp:
       {
@@ -197,6 +199,7 @@ i386_remove_point (enum raw_bkpt_type type, CORE_ADDR addr,
 {
   switch (type)
     {
+    case raw_bkpt_type_hw:
     case raw_bkpt_type_write_wp:
     case raw_bkpt_type_access_wp:
       {
-- 
2.26.2

Re: [PATCH] Enable hardware breakpoints for gdbserver on Windows

[Tom Tromey]

>>>>> "Hannes" == Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> writes:

Hannes> 2020-05-11  Hannes Domani  <ssbssa@yahoo.de>

Hannes> 	* win32-i386-low.cc (i386_supports_z_point_type): Handle
Hannes> 	Z_PACKET_HW_BP z_type.
Hannes> 	(i386_insert_point): Handle raw_bkpt_type type.
Hannes> 	(i386_remove_point): Likewise.

Looks good to me.
Thank you.

Tom

Re: [PATCH] Enable hardware breakpoints for gdbserver on Windows

[Hannes Domani]

 Am Donnerstag, 14. Mai 2020, 21:11:10 MESZ hat Tom Tromey <tom@tromey.com> Folgendes geschrieben:

> >>>>> "Hannes" == Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Hannes> 2020-05-11  Hannes Domani  <ssbssa@yahoo.de>
>
> Hannes>     * win32-i386-low.cc (i386_supports_z_point_type): Handle
> Hannes>     Z_PACKET_HW_BP z_type.
> Hannes>     (i386_insert_point): Handle raw_bkpt_type type.
> Hannes>     (i386_remove_point): Likewise.
>
> Looks good to me.
> Thank you.

Pushed, thanks.

Btw, is there no longer an automatic date update of bfd/version.h?


Hannes