From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 77530384640E for ; Thu, 25 Apr 2024 02:49:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 77530384640E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 77530384640E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714013400; cv=none; b=rqTT6nez/dSjuG3/PxBSmKcA/ZI8GEwwB3vPYDlBkIrLKXon0XDR2BK/r7piHjlXusOeUrrfLxg/DZa/I6Fpe1c6jPtyDN8CWMtzWpm5lJIgddcTw1c20bItAqN3sGH9PTp17HzAznsmVAEiQHBM/oVVqBi2Wxnwaar5MVRzsjM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714013400; c=relaxed/simple; bh=Cxvae7Rsyv1BvZsSdRG4ZynMVecmvMhytblqUwokkGc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=WIL2VRR9/WtH2sHh7yxtpxHXcfDVa1GmYohjG66C0PZTmxKvAc3SMZYWZwP5YYNeN5OjWM1J2N5+udfdui1O04T3hgXSk9zXgH6BOt7caV1y9IzN494L8VHCJ4iv1z2DIOFH5kDSwibjEqvLFBtukgaF5tZYOni/WO6gtmN1US0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1714013397; bh=Cxvae7Rsyv1BvZsSdRG4ZynMVecmvMhytblqUwokkGc=; h=Date:Subject:To:References:From:In-Reply-To:From; b=miEszD7JnHY4M33jFeDklQ7N1rd4D5kYOVDrMqICHICQ392fY0t50fwYhZ3CH6ymo 3MRQwqM2rfyVG6HmH8O0xT3cb6OLONdj3hckTz3+i3+1wQ6TiiiBskBTK7lwj6lTZ4 I3nuNPTnSX6GeRhyPnLTZM2w1FVLYzhs5XTOvvBg= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A79D01E030; Wed, 24 Apr 2024 22:49:57 -0400 (EDT) Message-ID: <94e85836-87f1-4185-a321-273a8c1fa32d@simark.ca> Date: Wed, 24 Apr 2024 22:49:57 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Improve target.h & target_ops & xfer_partial descriptions To: Pedro Alves , gdb-patches@sourceware.org References: <20240424144647.2849085-1-pedro@palves.net> Content-Language: en-US From: Simon Marchi In-Reply-To: <20240424144647.2849085-1-pedro@palves.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-04-24 10:46, Pedro Alves wrote: > Working backwards in terms of motivation for the patch: > > - When accessing memory via the xfer_partial interface, the process > that we're accessing is indicated by inferior_ptid. This can be > either the same process as current inferior, or a fork child which > does not exist in the inferior list. This is not documented > currently. This commit fixes that. > > - For target deletation to work, we must always make the inferior we > want to call the target method on, the current inferior. This > wasn't documented, AFAICT, so this commit fixes that too. I put > that in the intro comment to target_ops. > > - I actually started writing a larger intro comment to target_ops, as > there was seemingly none, which I did find odd. However, I then > noticed the description closer to the top of the file. I missed it > the first time, because for some reason, that intro comment is no > longer at the top of the file, as #includes etc. have been added > above it over the years. This commit fixes that too, by moving that > intro comment to the top. > > Change-Id: Id21f5462947f2a0f6f3ac0c42532df62ba355914 Thanks, this LGTM. Approved-By: Simon Marchi Simon