From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by sourceware.org (Postfix) with ESMTPS id 54A1C3857C6A for ; Wed, 22 Jul 2020 15:17:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 54A1C3857C6A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wr1-f46.google.com with SMTP id a14so2286286wra.5 for ; Wed, 22 Jul 2020 08:17:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2GTUOAaO3o0nnofihBmSWEehK7FsrOmVBNSrGTWgYSk=; b=HVB9oKKw39nkDnheQJvY9H/H3kYSMB2HwGtSSlD2MXnpOkTeO3lx3GcEzFB0ZifoTD BqiwvpjVJryp9JBhx4U7LrdKj80MvkGJiUeFB/hBcLg1w/o1ZN+NLeeo+qHinPpWhhQx yFkuQoccR0klvncEo7cOddxCo/pgWgYNwl/T2dvMt6mbo7gA0QG27Wd2XCVPnCGz5uDk oF4Gaab4IoSkwjb+HptgmPC+L3yVs0akhI+IHeOMZA7a0sadM/KGn2qqtIxqekRWjDiE YhtZKEMB6GZElqIcK0zm8wqJz1S8qNzXdUx6DzyVRAvH9xK0Vv2s/dPwmwfXFGrkRHRI azDw== X-Gm-Message-State: AOAM53094SsD/Yib80/N92DAa9WIg54y2eWHZarCvPlW8IJgo/SEWVOm Q1xGGZ/z8uX8xYW/D+qxqmRAsIi1FFc= X-Google-Smtp-Source: ABdhPJwSqJKcx0Op9ePJkYhC+4bIMHWkk4ocAMPBiFwMnmycXKaTcvfosqVKqOeijWXZOlY3mzn4GQ== X-Received: by 2002:adf:fd82:: with SMTP id d2mr100135wrr.72.1595431036652; Wed, 22 Jul 2020 08:17:16 -0700 (PDT) Received: from ?IPv6:2001:8a0:f91a:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f91a:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id l18sm257953wrm.52.2020.07.22.08.17.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jul 2020 08:17:15 -0700 (PDT) Subject: Re: [PATCH][gdb/doc] Fix to manual for description of remote protocol To: Reuben Thomas References: <5fbf55a9-2fe9-6018-79d5-7bcedf547f2f@palves.net> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <9589a0b3-9f16-dc03-70cd-84cf1f059ad5@palves.net> Date: Wed, 22 Jul 2020 16:17:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2020 15:17:20 -0000 On 7/22/20 2:58 PM, Reuben Thomas wrote: > On Wed, 22 Jul 2020 at 14:56, Pedro Alves > wrote: > > Thanks very much for the review! > > Note this should go to the gdb/doc/ChangeLog file instead. > > > Apologies, I didn't see that file existed. > > I see you're dropping the reference to the s (step) command. > However, either "s" or "vCont;s" _are_ mandatory if the target supports > hardware single-step.  E.g. an x86 stub that doesn't implement > s or vCont;s won't work. > > > Thanks for the correction. > > The choice of whether to require s is a little more complicated > than that, but I don't think we need to go into too much detail here. > > Do you think the version below is clear enough? > > > That looks great to me. Alright, I've merged it. Thanks!