From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id CF54C3857806 for ; Thu, 17 Aug 2023 08:23:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CF54C3857806 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 141B61F895 for ; Thu, 17 Aug 2023 08:23:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1692260629; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5deSQJpbiCnEpB7+VDC6jEOBBPZ7ZOE379tZxP0dsX8=; b=kTbyQEsuwjD7HDipzea9vBGsAnv8z9dJbglJp8VYFEdDK4OEvw0jVq63aubrSve1XBJnPF hGLqfjLQAqF3m3LHevH6dl/DMwTXHRR8R5pFwztlT12lPa6eXB/Z4KaYDmqhjlsIK8jnLy yLR2Ssj4FlWy8fSy6EpsIpg9umOA700= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1692260629; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5deSQJpbiCnEpB7+VDC6jEOBBPZ7ZOE379tZxP0dsX8=; b=2oc95s/Zfs+z6NdstpzwFT+uOFgy+52KoPk8j2bNPjOt+1DeZsmFHjm70JU1q2W9D4QTS8 hp5OS9V0na+DccCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 03DEA1392B for ; Thu, 17 Aug 2023 08:23:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id CHlZORTZ3WRsUwAAMHmgww (envelope-from ) for ; Thu, 17 Aug 2023 08:23:48 +0000 Message-ID: <95de8c6a-d12a-f9a5-4d97-367eece0271e@suse.de> Date: Thu, 17 Aug 2023 10:23:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/testsuite] Fix copy-to-remote in gdb.base/vfork-follow-parent.exp Content-Language: en-US To: gdb-patches@sourceware.org References: <20230817082154.23729-1-tdevries@suse.de> From: Tom de Vries In-Reply-To: <20230817082154.23729-1-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/17/23 10:21, Tom de Vries via Gdb-patches wrote: > When running test-case gdb.base/vfork-follow-parent.exp, I run into: > ... > ERROR: tcl error sourcing gdb/testsuite/gdb.base/vfork-follow-parent.exp. > ERROR: error copying "vforked-prog": no such file or directory > while executing > "file copy -force $fromfile $tofile" > (procedure "gdb_remote_download" line 29) > invoked from within > "gdb_remote_download target $binfile3" > ... > > Fix this by: > - making the copy-to-remote conditional on is_remote target, and > - allowing gdb_remote_download to find $binfile3 by using > standard_output_file. > > Also remove unused variable remote_exec_prog. > Sorry, forgot to mention: pushed. Thanks, - Tom > Tested on x86_64-linux. > --- > gdb/testsuite/gdb.base/vfork-follow-parent.exp | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.base/vfork-follow-parent.exp b/gdb/testsuite/gdb.base/vfork-follow-parent.exp > index 70b54e729a5..a29706f58c5 100644 > --- a/gdb/testsuite/gdb.base/vfork-follow-parent.exp > +++ b/gdb/testsuite/gdb.base/vfork-follow-parent.exp > @@ -30,7 +30,9 @@ if { [build_executable "compile $binfile3" $binfile3 $srcfile2] } { > return -1 > } > > -set remote_exec_prog [gdb_remote_download target $binfile3] > +if { [is_remote target] } { > + gdb_remote_download target [standard_output_file $binfile3] > +} > > set opts [list debug additional_flags=-DTEST_EXIT] > if { [build_executable "compile ${binfile}" ${binfile} ${srcfile} ${opts}] } { > > base-commit: 3afe50fe1974f9a13326a31696f5a93371ed00b7