From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id BD7CC395B058 for ; Tue, 12 May 2020 16:11:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BD7CC395B058 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.193] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 1FF961E79B; Tue, 12 May 2020 12:11:04 -0400 (EDT) Subject: Re: [PATCH 1/4] gdbsupport: Extend construct_inferior_arguments to allow handling all stringify_args cases To: Michael Weghorn , Christian Biesinger Cc: gdb-patches References: <20200429111638.1327262-1-m.weghorn@posteo.de> <20200429111638.1327262-3-m.weghorn@posteo.de> <1c46b1a7-4ce9-cab0-dd16-f1f6bf8d9df3@simark.ca> <96af7c9c-01d7-06ab-9645-6afaea4d26e5@posteo.de> From: Simon Marchi Message-ID: <95df013f-e9f7-62f0-8e7b-946918d5773d@simark.ca> Date: Tue, 12 May 2020 12:11:03 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <96af7c9c-01d7-06ab-9645-6afaea4d26e5@posteo.de> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 May 2020 16:11:05 -0000 On 2020-05-12 11:48 a.m., Michael Weghorn wrote: > On 07/05/2020 21.29, Simon Marchi wrote: >> On 2020-04-29 11:45 a.m., Christian Biesinger via Gdb-patches wrote: >>> On Wed, Apr 29, 2020 at 10:25 AM Christian Biesinger >>> wrote: >>>> >>>> Can you clarify which revision your patch is against? My files look >>>> nothing like the ones you are patching. >>> >>> Oh, I see now that this patch applies on top of the other patch series you sent. >> >> I was also confused, normally the patch 0/N is the cover letter, not a patch >> to apply. >> >> Simon >> > > Sorry for the confusion! It's the first time I'm contributing to a > project using this workflow and I misunderstood how to properly do it. It's not a big deal, it's just that I wonder how you did it. The headers of you messages say you've use git-send-email, and git-send-email numbers patches starting as one, AFAIK. > For the new version of the patch series, the patches now actually start > with "PATCH v3 1/6". > This also means that the patch numbers are no longer the same as in the > previous version, which was no longer the case due to added/removed patches. > > I've declared all patches as "v3", so all patches in the series have the > same version number again. (previous "[PATCH v2 1/4]" had v2 already, > while the others didn't.) That's fine, good choice. > > I hope this is OK, but am happy to hear about a better way to do this in > the future. No worries, the patch numbering was just a bit unexpected, that's all :). Simon