From: Pedro Alves <palves@redhat.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: Simon Marchi <simark@simark.ca>,
Keno Fischer <keno@juliacomputing.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Stop considering hw and sw breakpoint locations duplicates (PR gdb/25741)
Date: Sun, 17 May 2020 19:25:47 +0100 [thread overview]
Message-ID: <9651758c-772c-68d5-8cc9-b5610651b327@redhat.com> (raw)
In-Reply-To: <af11ec88-1c0e-91cd-dbe8-2f69dfc5b1ef@redhat.com>
On 5/2/20 9:13 PM, Pedro Alves via Gdb-patches wrote:
>
> gdb/ChangeLog:
> yyyy-mm-dd Pedro Alves <palves@redhat.com>
> Andrew Burgess <andrew.burgess@embecosm.com>
> Keno Fischer <keno@juliacomputing.com>
>
> PR gdb/25741
> * breakpoint.c (build_target_condition_list): Update comments.
> (build_target_command_list): Update comments and skip matching
> locations.
> (insert_bp_location): Move "set breakpoint auto-hw on" handling to
> a separate function. Simplify "set breakpoint auto-hw off"
> handling.
> (insert_breakpoints): Update comment.
> (tracepoint_locations_match): New parameter. For breakpoints,
> compare location types too, if the caller wants to.
> (handle_automatic_hardware_breakpoints): New functions.
> (bp_location_is_less_than): Also sort by location type and
> hardware breakpoint length.
> (update_global_location_list): Handle "set breakpoint auto-hw on"
> here.
> (update_breakpoint_locations): Ask breakpoint_locations_match to
> ignore location types.
>
> gdb/testsuite/ChangeLog:
> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>
> PR gdb/25741
> * gdb.base/hw-sw-break-same-address.exp: New file.
I've merged this now.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2020-05-17 18:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 1:38 [PATCH] breakpoint: Make sure location types match before swapping Keno Fischer
2020-04-14 7:01 ` Keno Fischer
2020-04-14 15:04 ` Simon Marchi
2020-04-14 16:00 ` Andrew Burgess
2020-04-14 16:26 ` Keno Fischer
2020-04-14 19:17 ` Pedro Alves
2020-04-15 20:46 ` Andrew Burgess
2020-04-17 12:28 ` Andrew Burgess
2020-04-17 17:22 ` Pedro Alves
2020-04-19 18:21 ` Pedro Alves
2020-04-19 18:49 ` [PATCH] Stop considering hw and sw breakpoints duplicates (Re: [PATCH] breakpoint: Make sure location types match before swapping) Pedro Alves
2020-04-20 9:02 ` Andrew Burgess
2020-04-21 16:24 ` Christian Biesinger
2020-04-21 18:31 ` Pedro Alves
2020-05-02 20:13 ` [PATCH v2] Stop considering hw and sw breakpoint locations duplicates (PR gdb/25741) Pedro Alves
2020-05-17 18:25 ` Pedro Alves [this message]
2020-05-17 18:50 ` Keno Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9651758c-772c-68d5-8cc9-b5610651b327@redhat.com \
--to=palves@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=keno@juliacomputing.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).