From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 60A163870847 for ; Sun, 17 May 2020 18:25:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 60A163870847 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-91-Pg3oOXIsO923Myjbjw4XcQ-1; Sun, 17 May 2020 14:25:50 -0400 X-MC-Unique: Pg3oOXIsO923Myjbjw4XcQ-1 Received: by mail-wr1-f70.google.com with SMTP id z16so4375164wrq.21 for ; Sun, 17 May 2020 11:25:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Snl6NElpAqbUyV6/XNJRVsNGNRvKPBan4MnhmkHyaHU=; b=GgFem2rEM6BZYuYKDhRVx6MH94uGE8+C4iRqR8HX9nDKrwvuWLQh/4H+Aov7CGGGMo cGA3wRNDYsfsPelOotWjtExcxzOVHOe9LgyclX4vjOPVO7RfyIkqAHZEpGrGwvZhGh2j Ap8BOdMCdqjRvQRdjZUQJig8/lc1DXKmwgopcBldoYP5pVhIxtBk5JkDgjaU13GtpJ43 ctstJY8HMZ8VOndjw8VX4FCrcWshcxRNIPfTIFgaWdt4h3gY8aWY1z+GdVm6ulZvbzuE zVXYXKphFQ9up6FHB8qaYpVAI3nBxGWglcgBTlRyLX8bBwSLrGPgmi2p8EyCL6oXIuQe muOg== X-Gm-Message-State: AOAM533zOpEjrzxGl/83IKVrQQ9y/VPJ3PlI/LVu+6W2K1g55NdKJTnV ybs1BXMp/0YTZcFn1DteoXuecUNeWoSjzOk8DRJWRkV3tNlLUDVSRLULwCSgyYV1y+6cfsUGt2E mb8Ek6lCfxm9IsHFSPAIKzw== X-Received: by 2002:a1c:de05:: with SMTP id v5mr14568452wmg.1.1589739949276; Sun, 17 May 2020 11:25:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwS/tWtXle/zO0dhX6xLLxXI7UveUmKl01Kr04XovMdpXMTs3oNKjx7P9jBlDelCkZs1Kktyg== X-Received: by 2002:a1c:de05:: with SMTP id v5mr14568437wmg.1.1589739949100; Sun, 17 May 2020 11:25:49 -0700 (PDT) Received: from ?IPv6:2001:8a0:f909:7b00:4eeb:42ff:feef:f164? ([2001:8a0:f909:7b00:4eeb:42ff:feef:f164]) by smtp.gmail.com with ESMTPSA id x17sm12598119wrp.71.2020.05.17.11.25.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 May 2020 11:25:48 -0700 (PDT) Subject: Re: [PATCH v2] Stop considering hw and sw breakpoint locations duplicates (PR gdb/25741) To: Andrew Burgess References: <20200401013813.GA27550@juliacomputing.com> <372f95e1-4591-7e0d-90c7-168477e032ba@simark.ca> <20200414160059.GG2366@embecosm.com> <41e51f15-6729-ccbf-7833-3a621006cdbf@redhat.com> <20200417122839.GK2366@embecosm.com> <16bb0282-652d-c6c5-3e47-a81dd827eef5@redhat.com> Cc: Simon Marchi , Keno Fischer , gdb-patches@sourceware.org From: Pedro Alves Message-ID: <9651758c-772c-68d5-8cc9-b5610651b327@redhat.com> Date: Sun, 17 May 2020 19:25:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 May 2020 18:25:53 -0000 On 5/2/20 9:13 PM, Pedro Alves via Gdb-patches wrote: > > gdb/ChangeLog: > yyyy-mm-dd Pedro Alves > Andrew Burgess > Keno Fischer > > PR gdb/25741 > * breakpoint.c (build_target_condition_list): Update comments. > (build_target_command_list): Update comments and skip matching > locations. > (insert_bp_location): Move "set breakpoint auto-hw on" handling to > a separate function. Simplify "set breakpoint auto-hw off" > handling. > (insert_breakpoints): Update comment. > (tracepoint_locations_match): New parameter. For breakpoints, > compare location types too, if the caller wants to. > (handle_automatic_hardware_breakpoints): New functions. > (bp_location_is_less_than): Also sort by location type and > hardware breakpoint length. > (update_global_location_list): Handle "set breakpoint auto-hw on" > here. > (update_breakpoint_locations): Ask breakpoint_locations_match to > ignore location types. > > gdb/testsuite/ChangeLog: > yyyy-mm-dd Pedro Alves > > PR gdb/25741 > * gdb.base/hw-sw-break-same-address.exp: New file. I've merged this now. Thanks, Pedro Alves