From: Pedro Alves <palves@redhat.com>
To: Kevin Buettner <kevinb@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v3 0/9] Fix BZ 25631 - core file memory access problem
Date: Thu, 25 Jun 2020 15:15:18 +0100 [thread overview]
Message-ID: <965c09c4-e2bd-eb4d-c3be-cd24f8acfdd0@redhat.com> (raw)
In-Reply-To: <20200618040824.3405657-1-kevinb@redhat.com>
On 6/18/20 5:08 AM, Kevin Buettner via Gdb-patches wrote:
> Nick Clifton has approved patch #1. It hasn't changed since approval.
>
> I think that Pedro is okay with patch #2, #4, and #5. They haven't
> changed for this v3 series.
>
> I made the updates that Pedro requested for patch #3, but it should
> probably be reviewed again just to make sure that I didn't mess
> anything up.
>
> Patch #6 is new, but it will need approval from a binutils maintainer.
> I'll attempt to CC it to that list.
>
> Patch #7 is new and will definitely require careful review.
>
> Patches #8 and #9 are also new. They add new tests for the cases
> which #7 now handles.
>
> So, in summary, patches #3, #7, #8, and #9 should be reviewed by a GDB
> maintainer. Patch #6 requires approval by a binutils maintainer.
>
Alright! Thanks for doing this. I sent some comments to patches
7 and 9, but otherwise this LGTM.
Thanks,
Pedro Alves
prev parent reply other threads:[~2020-06-25 14:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 4:08 Kevin Buettner
2020-06-18 4:08 ` [PATCH v3 1/9] Remove hack for GDB which sets the section size to 0 Kevin Buettner
2020-06-18 4:08 ` [PATCH v3 2/9] Adjust corefile.exp test to show regression after bfd hack removal Kevin Buettner
2020-06-18 4:08 ` [PATCH v3 3/9] section_table_xfer_memory: Replace section name with callback predicate Kevin Buettner
2020-06-18 4:08 ` [PATCH v3 4/9] Provide access to non SEC_HAS_CONTENTS core file sections Kevin Buettner
2020-06-18 4:08 ` [PATCH v3 5/9] Test ability to access unwritten-to mmap data in core file Kevin Buettner
2020-06-25 14:32 ` Pedro Alves
2020-06-18 4:08 ` [PATCH v3 6/9] Update binary_get_section_contents to seek using section's file position Kevin Buettner
2020-06-18 10:25 ` Nick Clifton
2020-06-18 4:08 ` [PATCH v3 7/9] Use NT_FILE note section for reading core target memory Kevin Buettner
2020-06-25 14:11 ` Pedro Alves
2020-06-18 4:08 ` [PATCH v3 8/9] Add test for accessing read-only mmapped data in a core file Kevin Buettner
2020-06-18 4:08 ` [PATCH v3 9/9] New core file tests with mappings over existing program memory Kevin Buettner
2020-06-24 2:44 ` Kevin Buettner
2020-06-25 14:12 ` Pedro Alves
2020-06-25 14:15 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=965c09c4-e2bd-eb4d-c3be-cd24f8acfdd0@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).