RE: [PATCH 5/8] Python: Introduce gdb.RecordGap class

["Wiederhake, Tim" <tim.wiederhake@intel.com>]

Hi Yao!

Renamed to reason_code / reason_string locally.

Regards,
Tim

> -----Original Message-----
> From: Yao Qi [mailto:qiyaoltc@gmail.com]
> Sent: Thursday, April 13, 2017 5:51 PM
> To: Wiederhake, Tim <tim.wiederhake@intel.com>
> Cc: gdb-patches@sourceware.org; Metzger, Markus T
> <markus.t.metzger@intel.com>; brobecker@adacore.com
> Subject: Re: [PATCH 5/8] Python: Introduce gdb.RecordGap class
> 
> Tim Wiederhake <tim.wiederhake@intel.com> writes:
> 
> > +If an error occured during recording or decoding a recording, this
> error is
> > +represented by a @code{gdb.RecordGap} object in the instruction list.
> It has
> 
> IMO, RecordGap is a hole in instruct trace, it can be caused by error,
> but can be caused by something else.  Suppose GDB wants to trace four
> instructions in every five instructions, that means there will be a gap
> after every four instructions.
> 
> In current implementation, the gap is caused by error, but we don't have
> to limit the interface to so.
> 
> > +the following attributes:
> > +
> > +@defvar RecordGap.number
> > +An integer identifying this gap.  @var{number} corresponds to the
> numbers seen
> > +in @code{record instruction-history} (@pxref{Process Record and
> Replay}).
> > +@end defvar
> > +
> > +@defvar RecordGap.error_code
> 
> How about RecordGap.reason_code?
> 
> > +A numerical representation of the reason for the gap.  The value is
> specific to
> > +the current recording method.
> > +@end defvar
> > +
> > +@defvar RecordGap.error_string
> > +A human readable string with the reason for the gap.
> 
> and RecoardGap.reason_string?
> 
> >  @end defvar
> >
> 
> --
> Yao (齐尧)
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928