From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 6AEE33858D33 for ; Tue, 7 Feb 2023 13:59:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6AEE33858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E3A8D1E0D3; Tue, 7 Feb 2023 08:59:44 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1675778385; bh=k0QThQWGblyr0i/9UFILcrNUfJ8s0fQ3WUg4FYDaE0Y=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=fnOnqQa7P70Sldi++OzZAYCcfbDdnm00ncPytMWkHNJ7BHeU51u805B7rebRerwaV V0S1V1XrJFTJvyccg57Genliut04juwRjPQxsQ7uLX5SIQ9aKqcexv0UoiwG3p4KWN v4sCVQkxS7u16OGfiuDgS1RTiy8OAUAk9RFb820I= Message-ID: <967b4fe3-905b-4b3b-603e-c0b8daabfb55@simark.ca> Date: Tue, 7 Feb 2023 08:59:44 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 3/4] gdb/testsuite: require amd-dbgapi support to run rocm tests Content-Language: en-US To: Lancelot SIX , gdb-patches@sourceware.org Cc: lsix@lancelotsix.com References: <20230207132802.223510-1-lancelot.six@amd.com> <20230207132802.223510-4-lancelot.six@amd.com> From: Simon Marchi In-Reply-To: <20230207132802.223510-4-lancelot.six@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/7/23 08:28, Lancelot SIX via Gdb-patches wrote: > Update allow_hipcc_tests to check that GDB has the amd-dbgapi support > built-in. Without this support, all tests using hipcc and the rocm > stack will fail. > --- > gdb/testsuite/lib/rocm.exp | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/gdb/testsuite/lib/rocm.exp b/gdb/testsuite/lib/rocm.exp > index 1440ac85d32..b5b59748c27 100644 > --- a/gdb/testsuite/lib/rocm.exp > +++ b/gdb/testsuite/lib/rocm.exp > @@ -22,6 +22,13 @@ proc allow_hipcc_tests { } { > if {[target_info gdb_protocol] != ""} { > return 0 > } > + > + # Ensure that GDB is built with amd-dbgapi support. > + set output [remote_exec host $::GDB "$::INTERNAL_GDBFLAGS --configuration"] > + if { [expr {[string first "--with-amd-dbgapi" $output] == -1}] } { The expr is unnecessary. Otherwise, LGTM. Simon