From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id DCFFD3858C62 for ; Mon, 7 Nov 2022 19:53:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DCFFD3858C62 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=us.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=us.ibm.com Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2A7I5BcS001686 for ; Mon, 7 Nov 2022 19:53:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding : subject; s=pp1; bh=0rG7yx+zhHFo7SAD+Ns7mIKvuDv2ZD1qChGY43EbjVI=; b=G2qolY0W0WyoCkUJxLhVykGRxJPjaBOsWrFIslGlyUtX1RTqccPmJhF4eLB3TFNDYVB0 svQTvLns+H6WEC4Kdc1jz10o0nR404tpxAucTYeh0hkLXf7DiwgEv6woda3jrNHMYNFL 1jMlp4EHGbhkJ+XzdS23JwsL3ogmTDC4x1K/t5NffD30wRk9oikR69SnafGfJfBSEcN/ Vcp9rDBosvF9aiHY0cf1wP1g3CYXSofdGGb9Vy4EQnVExQuVJn3wx0GiIAdGQrJOPV+Q sE1Qxx84JVTdjrU1Lkh91AZqxWlnEHtIoM5d7VD9OUI0sh6vHiDsHf912BP6bjVblXAI NA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3kp1mt0yqj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 07 Nov 2022 19:53:18 +0000 Received: from m0098410.ppops.net (m0098410.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2A7JnKto031624 for ; Mon, 7 Nov 2022 19:53:18 GMT Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3kp1mt0yq7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Nov 2022 19:53:18 +0000 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2A7Jo04Q003017; Mon, 7 Nov 2022 19:53:17 GMT Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com [9.57.198.25]) by ppma01dal.us.ibm.com with ESMTP id 3kngsxx81v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Nov 2022 19:53:17 +0000 Received: from smtpav04.wdc07v.mail.ibm.com ([9.208.128.116]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2A7JrGMt8061620 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 7 Nov 2022 19:53:16 GMT Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DEE5658050; Mon, 7 Nov 2022 19:53:15 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4249158045; Mon, 7 Nov 2022 19:53:15 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.163.10.231]) by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 7 Nov 2022 19:53:15 +0000 (GMT) Message-ID: <969f744ecae9c7565a904595f95ba645338b6fc8.camel@us.ibm.com> From: Carl Love To: Bruno Larsen , Ulrich Weigand , "gdb-patches@sourceware.org" Cc: will_schmidt@vnet.ibm.com, Kevin Buettner Date: Mon, 07 Nov 2022 11:53:14 -0800 In-Reply-To: <15eb0167-8f34-b2a6-0a5a-f0779785986e@redhat.com> References: <28ce795ca489f69829207b2a7a535cf7f77f6dd8.camel@us.ibm.com> <8decd662134d57e8caf43960a1cdc47723e2bfe3.camel@us.ibm.com> <79d82ed277308ed5ce312bff398e770ab234390a.camel@us.ibm.com> <63f21a897f452d81a73fb386cb99110a359ef0b7.camel@de.ibm.com> <97275f61ef101a12cde8e5a45008ed8e479424eb.camel@us.ibm.com> <191f5826b228a7614c084c9704b086851d418c78.camel@us.ibm.com> <5405a79ecd6ed34646ad77eed0779063ee222d37.camel@de.ibm.com> <1d55efe113cdcf96b812055ee45196a554c4ca78.camel@us.ibm.com> <7212dd858e43cf2ab38b568b124171bbcb181d28.camel@us.ibm.com> <15eb0167-8f34-b2a6-0a5a-f0779785986e@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: z_Q88VEvdVfikcOZc8DQXK9extimIfGb X-Proofpoint-ORIG-GUID: tXzhpEaPJqdIKQCdfzUnihq0pSL5k3KD Subject: RE: [PATCH 2/2 ver 2] PowerPC, fix support for printing the function return value for non-trivial values. X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-07_09,2022-11-07_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 bulkscore=0 phishscore=0 spamscore=0 clxscore=1015 priorityscore=1501 mlxscore=0 adultscore=0 impostorscore=0 mlxlogscore=833 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211070155 X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Bruno: On Mon, 2022-11-07 at 15:56 +0100, Bruno Larsen wrote: > This whole area of code is pure sorcery for me, but I do see that > the > patch fails to apply because of conflicts on gdbarch.c, due to Tom > Tromey's "Inline initialization of gdbarch members" patch, and some > style nits inlined. > > Sorry for taking so long to reply to this that it is not applying > again, > but in the future I wouldn't wait for my review if someone approves > the > patch. Thanks for the reply. I was hoping that Kevin would also let me know if all of his concerns had been addressed. I did fix up the two formatting issues you mentioned, rebased and retested the patch on the latest gdb source code tree. I will post version 3 of the patch and ping version 2 of patch 1/2 and see if we can get a maintainer to review the patches. Thanks for all the help and input. Carl