From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 765283858C98 for ; Wed, 15 Nov 2023 12:10:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 765283858C98 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 765283858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:67c:2178:6::1d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700050250; cv=none; b=oZH6+wpFu1OQtf5NxWnIiGox5RTlSwIHih9OXUJX4yUHo9N5t0DEXKcFyUfmowAHQ5PHqE39J4VJob6ZfcziRXKXEjqF6/mLJ+sNj2y29NZYiJ6Lop5ivV7BohkP1WrCJupb8et4AofBoXfZeO3Toom1seFRQ75WLnnHXo0qqQA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700050250; c=relaxed/simple; bh=f76ZoCrQBEj+JkBlJuXoAf5v++Uu9jGgHRw8mGOPQCU=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:From:To; b=sFg/vRvYAAFkhrsSFVul2IaIpt3Go86jHCNfPUC3HIhdGQu+EhmmBk7SsdGWS9ThfweFkQvQSimP7mM/R5yquA1Vyza9N/Zyx7kzGH+grxeb2viUS3BXK4MV3485ulHI2c0gMWwgVo6MUWJ8aJ4CY2PdWKyKNRnXBkhoD0TF85Q= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7237A204D9; Wed, 15 Nov 2023 12:10:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1700050247; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EWHT8Yi/xMVzbwCEO71bc2bL0TiEINgomAhS+t+Caeo=; b=L6lzU9aDYtjQOBm6nxzwUn2ngCKsSejMUeuq76c9e9NJXFacC2JcLjwx/OVYvhqI2eLZ8w SRWiivNplnwHK71JLWM/a7UfQ6OG3xgQFHyQfGf2jvpI8h060UTnjIcGipaetVqGQldk5q b+ftBxnEMoB5OPKvKwtvgNz7kio1DhY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1700050247; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EWHT8Yi/xMVzbwCEO71bc2bL0TiEINgomAhS+t+Caeo=; b=jZky29wuimygDVT3YHQYNQIeqq8R+RZoETLmdGNjiHEP8jOz02CwuYiOW60M9LAjak4sy4 9hNqp6svTJLAgdAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 60A3B13592; Wed, 15 Nov 2023 12:10:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id oxH6FEe1VGVsCwAAMHmgww (envelope-from ); Wed, 15 Nov 2023 12:10:47 +0000 Message-ID: <96bc9fec-6f2d-488a-b52e-2a987cf47d2c@suse.de> Date: Wed, 15 Nov 2023 13:12:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb] Fix assert in delete_breakpoint Content-Language: en-US From: Tom de Vries To: Simon Marchi , gdb-patches@sourceware.org References: <20231113152609.32726-1-tdevries@suse.de> <601592c1-4e19-42c8-bfd7-5671ef951ab3@simark.ca> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: smtp-out2.suse.de; none X-Spam-Level: X-Spam-Score: -7.09 X-Spamd-Result: default: False [-7.09 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-3.00)[99.99%]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-3.00)[-1.000]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_TWO(0.00)[2]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/15/23 12:12, Tom de Vries wrote: > Because it's deleted twice. Just to confirm this theory, I added this patch: ... diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index fe09dbcbeee..12a3a2260d7 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -12583,6 +12583,8 @@ void delete_breakpoint (struct breakpoint *bpt) { gdb_assert (bpt != NULL); + fprintf (stderr, "delete_breakpoint: %p\n", bpt); + fflush (stderr); /* Has this bp already been deleted? This can happen because multiple lists can hold pointers to bp's. bpstat lists are ... and got: ... [infrun] handle_signal_stop: [17091.17091.0] hit its single-step breakpoint^M delete_breakpoint: 0xabc756a8^M delete_breakpoint: 0xabc756a8^M /home/rock/gdb/src/gdb/../gdbsupport/intrusive_list.h:458: internal-error: erase_element: Assertion `elem_node->prev \ != INTRUSIVE_LIST_UNLINKED_VALUE' failed.^M ... Thanks, - Tom