From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by sourceware.org (Postfix) with ESMTPS id 5C3253858D1E for ; Thu, 17 Mar 2022 16:51:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5C3253858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f47.google.com with SMTP id h15so8189349wrc.6 for ; Thu, 17 Mar 2022 09:51:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=PFsscg5aA1a/Ml3Mt8SUIalOydF1STrCS4LF3d6N0uo=; b=H6QqoapIZB0c1PtItRIauPyteB8loNp6NFObrbIUxyJUb613MrqV3PW62Ae4yih2ON 1DymepaEVUjrFa9vr2ywJupfLrhTma7bklpfGeqO71vGCBskg6a/z889wXglML7PjLJ0 131ioETzCDprtXrUywQMt9evI8prGnsQ8AuKEiRTZfZwXi/Sq0IEBLyGsDGJqw+NqxWI a7XKeK1gUMBpKn87qVk87vP2/eWQtWWtPFjVOeH2ix239VRlNOMy0wb4dBR2eJtrXDHL uihge3itNZurW7RaZui2xPprduTsSQV/lXWBOiTwIB2BL5ishhBd0409rCSStYMzyXeu Nv+Q== X-Gm-Message-State: AOAM530JLijcjnhSas3FWzh3oaqjF94aWI7l9TZ9AbhjldiMJ6I21ZHO aN6A/+Q/SM17OTC2eA4AGinn1uDYQE0Snw== X-Google-Smtp-Source: ABdhPJwC1HrynOCi6tP/uKJM1VV6HXWM/ChNVRoqsinFWooOqDajIiLn0YmEvXCjH1F3XXIv9Vilyg== X-Received: by 2002:a5d:6b0d:0:b0:1f0:6497:b071 with SMTP id v13-20020a5d6b0d000000b001f06497b071mr4742763wrw.638.1647535886359; Thu, 17 Mar 2022 09:51:26 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id g5-20020a5d64e5000000b00203914f5313sm4454019wri.114.2022.03.17.09.51.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Mar 2022 09:51:25 -0700 (PDT) Message-ID: <96e3d038-d434-5d2a-d591-77af9eb8de43@palves.net> Date: Thu, 17 Mar 2022 16:51:24 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v3 3/4] gdb: testsuite: use gdb_attach to fix attach-pie-noexec.exp Content-Language: en-US To: Tiezhu Yang , gdb-patches@sourceware.org References: <1647525661-8607-1-git-send-email-yangtiezhu@loongson.cn> <1647525661-8607-4-git-send-email-yangtiezhu@loongson.cn> From: Pedro Alves In-Reply-To: <1647525661-8607-4-git-send-email-yangtiezhu@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2022 16:51:28 -0000 On 2022-03-17 14:01, Tiezhu Yang wrote: > diff --git a/gdb/testsuite/gdb.base/attach-pie-noexec.exp b/gdb/testsuite/gdb.base/attach-pie-noexec.exp > index 4712824..a916841 100644 > --- a/gdb/testsuite/gdb.base/attach-pie-noexec.exp > +++ b/gdb/testsuite/gdb.base/attach-pie-noexec.exp > @@ -59,7 +59,9 @@ set testpid [spawn_id_get_pid $test_spawn_id] > > gdb_start > file delete -- $binfile > -gdb_test "attach $testpid" "Attaching to process $testpid\r\n.*" "attach" > +if { ![gdb_attach $testpid] } { Should call kill_wait_spawned_process $test_spawn_id here before returning. > + return > +}