From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by sourceware.org (Postfix) with ESMTPS id 9E961385840C for ; Thu, 28 Apr 2022 16:14:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9E961385840C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f42.google.com with SMTP id u3so7451387wrg.3 for ; Thu, 28 Apr 2022 09:14:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=+DTxNbNLoivZ/syoiJblT4xAHmVkXgAEjfhnBA5Qkbg=; b=8AvqlDvwkTp/ylAAV3nAwe9ScrvRKuJf+8wsjzhheTvb+1eq3QrhavDuYW9xNRETiC 0iWMUimsd4/OQ8DJjyov1VUEqwrcGQdyfKc05N+nheeWKbWc/3nSZUP6VMPrrgRpCzR1 vwNQ7HL/hcLl1pKkSmoDhKC9LkbVj3zD+OKkx1feQPMuLBw0uuIjGRx+TcPmyBk9WzKP /vcCQZZhK2QDk4gA23jydLJnPYrknyIn+To+HLj+W5/BE1uFGPvvU++B2kK+jSQZXOHR Pcp0yUfnIRHQi31r6By5ZoHrV2OcHVyBmWSIaM3N0vDwsWPGkLEai5AOLPTwrqDXlkOO 2DAA== X-Gm-Message-State: AOAM530r5B24uD2ZlDFHVdYConrEsX9XscrXSAbJW3VWcmvSl1DfDjmL XnokpJWImfd4ALSxRI6FQTPsu4/Ky5YBzg== X-Google-Smtp-Source: ABdhPJyTlEcoc90Mo7IaXZLSK0I+C6M/5mjl0EbwTtBu8eWQfpDr+ss0f9Yjp9ZVB1bKc5td+uaF8A== X-Received: by 2002:a5d:6d03:0:b0:20a:f15e:8b4 with SMTP id e3-20020a5d6d03000000b0020af15e08b4mr6768741wrq.451.1651162482361; Thu, 28 Apr 2022 09:14:42 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id k65-20020a1ca144000000b003929a64ab63sm4432657wme.38.2022.04.28.09.14.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Apr 2022 09:14:41 -0700 (PDT) Message-ID: <96f68c7d-9887-1a90-060c-e8f5afdc0103@palves.net> Date: Thu, 28 Apr 2022 17:14:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v3 1/1] get page size using sysconf (_SC_PAGESIZE) instead of PAGE_SIZE Content-Language: en-US To: Zied Guermazi , gdb-patches@sourceware.org References: <20220428115002.13735-1-zied.guermazi@trande.de> <20220428115002.13735-2-zied.guermazi@trande.de> From: Pedro Alves In-Reply-To: <20220428115002.13735-2-zied.guermazi@trande.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Apr 2022 16:14:46 -0000 On 2022-04-28 12:50, Zied Guermazi wrote: > + if (page_size == -1) > + perror_with_name (_("Failed to get system page size: %s")); Sorry, my fault here -- the ": %s" part shouldn't be there. You want just: perror_with_name (_("Failed to get system page size")); (I have not read the rest of the patch in any detail.)