From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 00FB63858D33 for ; Thu, 16 Feb 2023 19:33:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 00FB63858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.192] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 00A9B1E110; Thu, 16 Feb 2023 14:33:01 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1676575982; bh=qDsD4wC/dSw6JOc5fwpbqWUYCbain8au8lpLVKzj87c=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=EVtnIzc7SRgr25BrdblVaIUuyLuOX1OUMGxIh5PKt/b3oDAf1+hb+KYuvv2jNc78d qXJV4wzvQgeOOERYm1CLyLAFl7Q4dkEHXOQD1/jfEK8lcLFaIkfBURu6DWvuCLFjfU V1vV3yQfMaYJIPK2ywaDxZWRAKwoAPbij1NQr3Nc= Message-ID: <96fb5549-ed77-2eda-8368-c3f7b4e087f8@simark.ca> Date: Thu, 16 Feb 2023 14:33:01 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH] Do not record a rejected target description Content-Language: fr To: Tom Tromey Cc: Andrew Burgess , Tom Tromey via Gdb-patches References: <20230112193356.1133696-1-tromey@adacore.com> <87bklwmenh.fsf@redhat.com> <875yc4tawn.fsf@tromey.com> <875yc3m6in.fsf@redhat.com> <871qmqsyvu.fsf@tromey.com> <87zg9do1s6.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87zg9do1s6.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/16/23 14:20, Tom Tromey wrote: > Simon> I see: > > Simon> maint print c-tdesc^M > Simon> There is no target description to print.^M > Simon> (gdb) FAIL: gdb.xml/maint_print_struct.exp: printing tdesc with a structure and a bitfield > > Here's a patch that avoids this problem. > Let me know what you think. > > Tom > > commit a12897d22ccc1d927960fa411b99723d76620af0 > Author: Tom Tromey > Date: Thu Feb 16 12:17:50 2023 -0700 > > Fix regression in maint_print_struct.exp > > An earlier patch of mine caused a regression in > maint_print_struct.exp. This patch fixes it by modifying the test so > that it does not rely on the erroneous target description being > available. I don't have time to dig in the implementation to review, but I confirmed it fixes the problem on my side, so: Tested-By: Simon Marchi Simon