Re: [PATCH 3/3] [gdb/python] Replace gdbpy_should_stop with gdbpy_breakpoint_cond_says_stop

[Bruno Larsen <blarsen@redhat.com>]

On 20/09/2022 19:24, Johnson Sun via Gdb-patches wrote:
> In 2014, the function `gdbpy_should_stop' has been replaced with
> `gdbpy_breakpoint_cond_says_stop'
>
> This replaces `gdbpy_should_stop' with `gdbpy_breakpoint_cond_says_stop' in the
> comments.
>
> Since `gdbpy_should_stop' has been renamed as noted in `gdb/ChangeLog-2014':
>
> 	* python/py-breakpoint.c (gdbpy_breakpoint_cond_says_stop): Renamed
> 	from gdbpy_should_stop.  Change result type to enum scr_bp_stop.

Hi Johnson!

Thanks for cleaning this up! This looks obvious enough for  me, but I 
can't approve patches to be pushed. I hope a maintainer looks at it soon.

On that note, do you have a reason to have sent this along with the rest 
of the patch series? It doesn't look directly related, and patch series 
tend to take a longer time to be reviewed, so you may have better luck 
submitting unrelated things separately in the future :-)

Cheers,
Bruno

> ---
>   gdb/python/py-finishbreakpoint.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/python/py-finishbreakpoint.c b/gdb/python/py-finishbreakpoint.c
> index a219bc82f15..d608c95be0f 100644
> --- a/gdb/python/py-finishbreakpoint.c
> +++ b/gdb/python/py-finishbreakpoint.c
> @@ -90,7 +90,7 @@ bpfinishpy_dealloc (PyObject *self)
>     Py_TYPE (self)->tp_free (self);
>   }
>   
> -/* Triggered when gdbpy_should_stop is about to execute the `stop' callback
> +/* Triggered when gdbpy_breakpoint_cond_says_stop is about to execute the `stop' callback
>      of the gdb.FinishBreakpoint object BP_OBJ.  Will compute and cache the
>      `return_value', if possible.  */
>   
> @@ -134,7 +134,7 @@ bpfinishpy_pre_stop_hook (struct gdbpy_breakpoint_object *bp_obj)
>       }
>   }
>   
> -/* Triggered when gdbpy_should_stop has triggered the `stop' callback
> +/* Triggered when gdbpy_breakpoint_cond_says_stop has triggered the `stop' callback
>      of the gdb.FinishBreakpoint object BP_OBJ.  */
>   
>   void