From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D1CAB3858C62 for ; Wed, 21 Sep 2022 14:09:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D1CAB3858C62 Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-520-YVgrZ0dDPjmaQGcb4FmJHw-1; Wed, 21 Sep 2022 10:09:32 -0400 X-MC-Unique: YVgrZ0dDPjmaQGcb4FmJHw-1 Received: by mail-ed1-f70.google.com with SMTP id b16-20020a056402279000b0044f1102e6e2so4606047ede.20 for ; Wed, 21 Sep 2022 07:09:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=v+7xZIN3NXM8T6Rpgw6vohtfIyxOaewkr8JCRGj/6ic=; b=0pPFw0IR7NhfYhKJFl7PBv2blCbCFqIkeHZI551MJzupqUrfNKroHNBdo/ZHTcJzc2 sNosDVyoP3QVZJzmLyZuTKWdT+/HwOOkd2ciTK1utu/t88GeGzIJOPAvhKx2sVHyB3bj 5CN8padmtg9pSPlp1xbkb/2Uxe059Lrvj9YCpqhRtIB8SuwXrAA+iuCDCAWXHF5lriP5 soU4FG1WkHy9gd9cIji5klQDusKjypKIN36UroGmHNpkEWjfWfWOa5RMGG3ffMwJY9FF UNHMJuBPK52NEsR5C0HOswSyzEMwROxRj5PE5LB3w3GMQBpHE2IWtIwjm1t6rF9LiJ1J Dudg== X-Gm-Message-State: ACrzQf0iNrW8iG32+umAuX3i/kbmBu6TSQIrRob4JohlSMUISbCi1WQe haQPKSrTl6LdOwTTcuwuzD2ABicPkFJXE18RDO9q55VUlV1bUXis7egy68ATQYV/4rOVjGZfL1d DWi74MZiTy3QQ6Pkla5KH0NB5WjLb3/+AdnukADBuKRY2oveMtFwHE7mbJmFYYRw2fW3+hrAq X-Received: by 2002:a17:906:9b8f:b0:77b:2b61:ae2d with SMTP id dd15-20020a1709069b8f00b0077b2b61ae2dmr20561058ejc.50.1663769371213; Wed, 21 Sep 2022 07:09:31 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4pAgzMOGbaUmhVLSMrze9/CHPGr60OMNa6Re5VzYGRjuBqEEwqHVH4epDjJbTb3YU98oJCXQ== X-Received: by 2002:a17:906:9b8f:b0:77b:2b61:ae2d with SMTP id dd15-20020a1709069b8f00b0077b2b61ae2dmr20561035ejc.50.1663769370927; Wed, 21 Sep 2022 07:09:30 -0700 (PDT) Received: from [192.168.0.45] (ip-213-220-232-121.bb.vodafone.cz. [213.220.232.121]) by smtp.gmail.com with ESMTPSA id h23-20020a170906399700b00773f3cb67ffsm1347794eje.28.2022.09.21.07.09.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Sep 2022 07:09:30 -0700 (PDT) Message-ID: <97119feb-918f-3bba-331e-ef028092e7fa@redhat.com> Date: Wed, 21 Sep 2022 16:09:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH 3/3] [gdb/python] Replace gdbpy_should_stop with gdbpy_breakpoint_cond_says_stop To: gdb-patches@sourceware.org References: <20220920172426.90659-1-j3.soon777@gmail.com> <20220920172426.90659-4-j3.soon777@gmail.com> From: Bruno Larsen In-Reply-To: <20220920172426.90659-4-j3.soon777@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-14.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2022 14:09:40 -0000 On 20/09/2022 19:24, Johnson Sun via Gdb-patches wrote: > In 2014, the function `gdbpy_should_stop' has been replaced with > `gdbpy_breakpoint_cond_says_stop' > > This replaces `gdbpy_should_stop' with `gdbpy_breakpoint_cond_says_stop' in the > comments. > > Since `gdbpy_should_stop' has been renamed as noted in `gdb/ChangeLog-2014': > > * python/py-breakpoint.c (gdbpy_breakpoint_cond_says_stop): Renamed > from gdbpy_should_stop. Change result type to enum scr_bp_stop. Hi Johnson! Thanks for cleaning this up! This looks obvious enough for  me, but I can't approve patches to be pushed. I hope a maintainer looks at it soon. On that note, do you have a reason to have sent this along with the rest of the patch series? It doesn't look directly related, and patch series tend to take a longer time to be reviewed, so you may have better luck submitting unrelated things separately in the future :-) Cheers, Bruno > --- > gdb/python/py-finishbreakpoint.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/python/py-finishbreakpoint.c b/gdb/python/py-finishbreakpoint.c > index a219bc82f15..d608c95be0f 100644 > --- a/gdb/python/py-finishbreakpoint.c > +++ b/gdb/python/py-finishbreakpoint.c > @@ -90,7 +90,7 @@ bpfinishpy_dealloc (PyObject *self) > Py_TYPE (self)->tp_free (self); > } > > -/* Triggered when gdbpy_should_stop is about to execute the `stop' callback > +/* Triggered when gdbpy_breakpoint_cond_says_stop is about to execute the `stop' callback > of the gdb.FinishBreakpoint object BP_OBJ. Will compute and cache the > `return_value', if possible. */ > > @@ -134,7 +134,7 @@ bpfinishpy_pre_stop_hook (struct gdbpy_breakpoint_object *bp_obj) > } > } > > -/* Triggered when gdbpy_should_stop has triggered the `stop' callback > +/* Triggered when gdbpy_breakpoint_cond_says_stop has triggered the `stop' callback > of the gdb.FinishBreakpoint object BP_OBJ. */ > > void