From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) by sourceware.org (Postfix) with ESMTPS id 23B31385DC0B for ; Thu, 23 Apr 2020 17:51:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 23B31385DC0B Received: by mail-qt1-x841.google.com with SMTP id 92so5625456qtg.0 for ; Thu, 23 Apr 2020 10:51:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0vpJxlSOjhsQlPQUlJj1Ry/MZmEDBss/cRaWVDtdH4U=; b=MfFjRKAiirumJbIrDQssx45ZdI2nDKKXhRxzZ2eFjbdB07qbjUj3vg7NrLfFe/GvFL sqitGo7brfoN/WBY+MnbHfgXr0JLNlPxxDoHarGQ8KfYM0QHT1WUkYzC/b4MZb0np9bk QRXgbn1PDw42UQo8qXxAFoDBCIH+Q3XYGrVIs2UIs8xnHhD7qQCjPXAGcv/FZUmlDZ7T BLfGS/cK9ersQVVAidtvn4L4Rn5SQlRqNQhtGVixO4iCBX6QSLXjj3ZBj+mBIT63Bao0 aVbCQoeAOwmHkxIN6jfiwnrr8d24mJ+Xv9RLm6CzcyF4Q76FyMnSfEi30tZV91rdOWAX aycg== X-Gm-Message-State: AGi0PubMKhYzgDTCZo+xPscEYbwb2P0AjUNHNfb3rhfXMn8AANUvoF+b azFBaWsbdKdp/KxatCbjeTz1IUYTzhM= X-Google-Smtp-Source: APiQypItcxYm8ZFoJCq0a3xRLc9ECyq7+v0D0y1UXNdWw9DXAfuLfCsLZ9MfmZM6txjrCPHBmaDleA== X-Received: by 2002:ac8:6c57:: with SMTP id z23mr5322037qtu.359.1587664312403; Thu, 23 Apr 2020 10:51:52 -0700 (PDT) Received: from [192.168.0.185] ([191.34.80.110]) by smtp.gmail.com with ESMTPSA id f68sm2026139qtb.19.2020.04.23.10.51.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Apr 2020 10:51:51 -0700 (PDT) Subject: Re: [PATCH] Fix inline frame unwinding breakage From: Luis Machado To: Andrew Burgess Cc: gdb-patches@sourceware.org, tromey@adacore.com References: <20200414213137.24015-1-luis.machado@linaro.org> <20200414213836.24370-1-luis.machado@linaro.org> <20200422093723.GA3522@embecosm.com> Message-ID: <9722a14e-83af-03c6-b120-aac9816f9fc9@linaro.org> Date: Thu, 23 Apr 2020 14:51:47 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Apr 2020 17:51:54 -0000 On 4/22/20 8:22 AM, Luis Machado wrote: > Hi Andrew, > > On 4/22/20 6:37 AM, Andrew Burgess wrote: >> * Luis Machado via Gdb-patches >> [2020-04-14 18:38:36 -0300]: >> >>> *** re-sending due to the poor choice of characters for the backtrace >>> annotations. GIT swallowed parts of it. >>> >>> There has been some breakage for aarch64-linux, arm-linux and >>> s390-linux in >>> terms of inline frame unwinding. There may be other targets, but >>> these are >>> the ones i'm aware of. >>> >>> The following testcases started to show numerous failures and trigger >>> internal >>> errors in GDB after commit 1009d92fc621bc4d017029b90a5bfab16e17fde5, >>> "Find tailcall frames before inline frames". >>> >>> gdb.opt/inline-break.exp >>> gdb.opt/inline-cmds.exp >>> gdb.python/py-frame-inline.exp >>> gdb.reverse/insn-reverse.exp >>> >>> The internal errors were of this kind: >>> >>> binutils-gdb/gdb/frame.c:579: internal-error: frame_id >>> get_frame_id(frame_info*): Assertion `fi->level == 0' failed. >> >> I have also started seeing this assert on RISC-V, and your patch >> resolves this issue for me, so I'm keen to see this merged. > > Great. > >> >> I took a look through and it all looks good to me - is there anything >> holding this back from being merged? > > Not really. I was waiting for an OK before pushing it. > >> >> Thanks, >> Andrew I've pushed this now. Tromey and Andrew OK-ed it on IRC.