From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YT3-obe.outbound.protection.outlook.com (mail-yt3can01on2067.outbound.protection.outlook.com [40.107.115.67]) by sourceware.org (Postfix) with ESMTPS id 3CDF93858D20 for ; Mon, 15 May 2023 18:25:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3CDF93858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HCeL7PP4X6WA7y2uiVobTS57vj0CR+qmefPaWfZpKNVkjbdnaQxsLjAY9lli14m0B9ziBkEGU9mNLBGiPAOi5o9HyVgcMuzzBROfaGICJstiLuJOhl/GLS8fX5X6tPvt7kdFKjuOkUlVH7jf00jcBRHzIJ/kd+k/ppLSN3EODPPIh5LA1sEkHqjpUAyRry/v9S+JP/Je21e0AKIUhh87CXNS2sBG1JEkO+sTMxJ5w0+P722nCXIh7fe3yvdbOvgAZnnk7P01/KUYng+OS5pjfE1vwYwcz8LcztgqIjbzZdRI+7o8tA/pG+IY4IUnH6FgR7A2TFPRn4PhwshxAMShrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+4a8mTDmXqL12C+MlvF+b84iD4WN+mlVQO2ZF5O63aw=; b=Ndd6ZWcFsb4XIjKePhGYVHF/tAx/HbUw4VfsHLwqjtPc9YNs1RUBwuGQYE0CiLzb5q/G8xKBmS8eTxt0uiQZOzWvSe/s3mMlQewscBEKF/wSoComu7f/vV0Wx/Rsbab50EeBH3WgWX3oJMaEmXLxJ6Xud95YvSFHH3VcLhzFygsv0lqiVzJBv0abNCbkMPqhJ3PpAPehil76o5GaLytEeR71tOgqW4lQRh5oiU8BhnmJiQt6WcwrJMnAaKOw1ttoe5e2/nPTvZRK0+NAdtqs/bS36s1KdmH6RtO7ZeKSDZ+t/9vsnK+5N96jJvmehe07ENsZTAcmcjJrO6PopsG9Cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+4a8mTDmXqL12C+MlvF+b84iD4WN+mlVQO2ZF5O63aw=; b=dNqIMESj8U66mWufKPL+Av/GGHFpYFn3+fQ4nIJojqD47xIfm0On497SADAJU2FIZ0udhBLTxqNKhNrc96OulQBrrR7+aa7qCFrNrwHBXE6Mglyh5gYPm6Vnb3KxQrcg5HfLkbAk7HWxqBN/Kw7sL59znZYyL4OUWXlB3HJhqcKd1kO+gmdNzrQ3geQuDpjsyQIJFO7oAJuiS+lzvJyDU6whC2vXQArkIZ41aVRHuW0weS+fzp6AXBAo9x8kLYm1zU9W/Rw3EH4MpK3w5uQzmjUJDpWfxDORhF7QRKJKaQIAJw3G8Kplq2djtorZSZzBMgsJ40V/CgklWARl3r9G8Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YT1PR01MB8684.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:c9::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.30; Mon, 15 May 2023 18:25:04 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::b7c2:2912:524e:8e80]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::b7c2:2912:524e:8e80%6]) with mapi id 15.20.6387.030; Mon, 15 May 2023 18:25:04 +0000 Message-ID: <9758578b-81aa-6ee4-90e5-be8ed4c024f3@efficios.com> Date: Mon, 15 May 2023 14:25:02 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 02/12] gdb: make some breakpoint methods use `this` Content-Language: fr To: Alexandra Petlanova Hajkova Cc: gdb-patches@sourceware.org References: <20230511144832.17974-1-simon.marchi@efficios.com> <20230511144832.17974-3-simon.marchi@efficios.com> From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: YQZPR01CA0014.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:85::27) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YT1PR01MB8684:EE_ X-MS-Office365-Filtering-Correlation-Id: 2a6c4700-21b4-4740-3ec8-08db5571b40d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mGlOnxjg7egpZzhVN9klukfTkXS0mgCLQQ29avFUqBJ5sVbMGGjua2nPgsPfUJwRLpOf/jdqJ6qH/F06Ri5paN4fqjVWUSsDZWeu7YFNbWAlHXplpWssxSYrPPDnEhKODv1hFOE4ufcHnCtKDk1SLCTQu/mMq2ip4bTzwjFBPVWFlBgXhY5rkoAEoEl4ifzkDMy67/qAi+otI2vGlSRgQ2F3r0rdZUUcBkHQsM6ilpLv7UqwGIoW1BhGPTYQp4J5qE6wBd8K0j7XmBl0qvbaH5D/r961e1SRuTYueVqfu5S2/7AQzKhPXrmDqvH/EwUlBQr3g5HnBcjRApJgSQ2QfX0YQN48+YPyaZUtezRoz7cqFFBlL6eIkY28R+gPjAmoCCkZo2mU4C0kAz4sFi9YsGCWSHBsxskvA3B4jnVKC20wXGNNtasx9JL1BhPr84Cyr6f9SFWR7lCHdt2G+Pn1j4kyTK1Vq6vqpz4pI/TuKPbOgiwVfYTJyBQw9MpHSNjAcpfxjABmsRRqK8sqb5ucCvuDvFCz/IAXiX7GUU/AOLsIR55FAmqWc8KW3nhv0bYE777EObJiHODBLkqAIIbF5w9ZwknlL09pKCLknlmuz8tRPhsK1lMh5EV4DtpQsDyjpKNwTsn4KQNFHJQwQuCQEo3+1eZKmjZ0rpt4BxDzGus= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230028)(136003)(39830400003)(376002)(346002)(396003)(366004)(451199021)(6486002)(83380400001)(478600001)(2616005)(6506007)(26005)(6512007)(186003)(53546011)(44832011)(4744005)(2906002)(36756003)(6916009)(4326008)(38100700002)(66476007)(66556008)(41300700001)(66946007)(8936002)(8676002)(5660300002)(31696002)(316002)(31686004)(81973001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L25iYnU3RlZSaGFVblpjcTNsTTZpanJVdUJsWDFWcWIrWnE4V0FnR1pMOHQ4?= =?utf-8?B?WGtHcFFqR1U1TDdvcXVQTVVkZTFNdTdDUUlHd3k5NnhLVmxZTVBHZEUrSnFZ?= =?utf-8?B?MXZoaThSUGVBN1ZldWluZHFtMW1CY1NIN0dCUkFBMzhkSWUvNVhwZUtSUUFT?= =?utf-8?B?bmRrNm1aZEpsTHFiL3hjcFpyUlFWMHdkU2xWeCtVM0tyZE5WQVJqQ0tiTGsz?= =?utf-8?B?Ry81dnlrTDdwMEpSUXRYZUpkaG5RWTBLUHpaMDYwTmZKdDU0WjFubTFRNjZn?= =?utf-8?B?eEdPWHBScXV2TkdHSHdtSDl4NEd3YldldVladE50azJGMnp6dEZjTGJYZ2t2?= =?utf-8?B?T0tLMmhscW02dytOWHdqUG41d3lSUklDcHdZRi9kKy9LVUxJWVhlQTY5ZmFn?= =?utf-8?B?UzZXSGNta0NySy9oaUJrdzhhUVAydThVN0M3UytJTXQxRFNMVjFOZmNFTU9w?= =?utf-8?B?L3JibXF0b0YzY0JMVytRa1BMRjdqeEltSFJkTHdkdFQ4a01JWlJhZ2U2aG1q?= =?utf-8?B?eDBXaUE1aXcybUpKL2ZUcFlRQ1E2VnpjcS94clNLc09nZC8vSENhK0xpUStG?= =?utf-8?B?Vk10VnhFcFRBRGh0b3Y5cDhjaEF3cW80ZWxzb2pTZ3hsa294dW1Va3pHaHk3?= =?utf-8?B?U2V2SXYzaUZIVVd1M0xQcHBCaW90UDJMR3FhUXgrdDhtV1NEbFhUWGNlKzdo?= =?utf-8?B?Q2IzeHEzU2xNZEh2dzB6ZWlvMVF0bjRXbFBtVzBrNFA1Vmh3b2VaQmMyaWQ4?= =?utf-8?B?RkgrVnJQcG12YkNLTnQzdW9peTFyRUFpTVIzRy8zT0p5MlM2aHg4S2czL25H?= =?utf-8?B?NXBtdzRRdGNwUU0welgrSmZzeXd5SG0vcjRtRGg3UnNtaGlyVE9PTmhlT0cy?= =?utf-8?B?MGlxMXBNRXNlcmdHVFBrYjJHOTgxam5LVlNiWVVmUzQ2bzVtTytZL0t1d3pr?= =?utf-8?B?WjRTV2ROSFVrWVV5WDJGQ1VQVFVDbDA0bldVc0RwenNMVnpTaVNHMkRGLzA4?= =?utf-8?B?TFZzcXVwQ0dqRDV5c0Zyd21sMlhUTk1NenplQTV5bUpaT1REQ2JxT1JUb0pX?= =?utf-8?B?dEVjcG1yNE9ZZWJpUmpYYzFlNEdLSkgrR1V4a3FFdjVqNHVWZFFzZFByam5D?= =?utf-8?B?dHhEeTBjR2VEanIxRUo4NUw2WGdKZ0lySThLMmNRTEZUb2ZSK0FDTkk4TFVG?= =?utf-8?B?bjJkQzZtNFNFakVSL0pkeWEzcWlmUk9UNytlKzJqa1BQbmFvY3E4TSt6TWFw?= =?utf-8?B?NktkdC9WTGJmWjBYSnB1SDhUL241ZnBNOHNhZXJoV2V0OFdRRFBrSlk0KzFW?= =?utf-8?B?TkU1ajhJZkpJWDBrYWNNMGZPTWR0Y2RWcmFGRXgzV2t6RURZMjVjbU9xeFhk?= =?utf-8?B?TGZzbTM4eUpTTnI0S3F0SU15bEtJV01nZzl5TngybjRRR1hyRTlZR1IyYlRa?= =?utf-8?B?STJrK2ZPeUxGTHpzYTB2YlYrK3cyYS9XSDVJbGQ2U0E1NGJjeHFvNXNGMzNw?= =?utf-8?B?S2x0MTBTSk84eG83Y0pJamF5Z1I3YXR0OFovbjlCcjFkT3N0ays2STh2Tlgw?= =?utf-8?B?T3ZGa3B0bHhJSE5sTDhoWDRhNGI0bHcyNGtEV1lJMHl2a0lScXdKN2ZWMktV?= =?utf-8?B?MkFCcnpnTWZsVDBNcFpabjM2UFJKS0JabFd1aFhxU3ViSGhvWTRWOHhxYnhn?= =?utf-8?B?K01Jd0t1YmI1OE1ZL21lRCs3WHR4VndLUG1GWVZkYk5Sb3NTZ1VCTWFJbkRS?= =?utf-8?B?WGJtT0ovbDJQclVpQVRwWTlRRko0anlwNk5sMVhpVFFNN2Z0NndYbmg4NVJZ?= =?utf-8?B?SDdHeUIvMHZmWEp2TVdEM29TUGJ1MFN3UFBJelgxTUhsaXdOd0Y3SE5PV05y?= =?utf-8?B?cXl5emI0MEZRdVBuTHlYNjJFSHNveHI1b0lxeCtBeTluRHZEVkt5MEZlUWxx?= =?utf-8?B?YnZMcGI2dEpmUVpqamd0RXRtV2VDcWxvbFlxQnlEajBveWEvdEhBSldrSkdp?= =?utf-8?B?OHB5b3hVbitJRVVlSFpYbnNDKzVydXEyMUZubE9wblBmYWFBR1p3NlZMdTZV?= =?utf-8?B?UERwczVCcUZMd0JNK0hHb25DWFY2S1pyNHRUSS90NWRaRm1uRi83QUxYOUtK?= =?utf-8?Q?NgiDIzeL6wEUNcY58Prba/GyV?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a6c4700-21b4-4740-3ec8-08db5571b40d X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2023 18:25:04.7222 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SsucHWamntVBNA5FI7To27q7TbK2SZBFC4pzdm8DBUinVxrCfuGi2xreP5S5k31tEkgu7B7x7ap+7uL1nCvPMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT1PR01MB8684 X-Spam-Status: No, score=-3034.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/15/23 09:12, Alexandra Petlanova Hajkova wrote: > > > On Thu, May 11, 2023 at 4:49 PM Simon Marchi via Gdb-patches > wrote: > > Some implementations of breakpoint::check_status and > breakpoint::print_it do this: > > struct breakpoint *b = bs->breakpoint_at; > > bs->breakpoint_at is always the same as `this` (we can get convinced by > looking at the call sites of check_status and print_it), so it would > just be clearer to access fields through `this` instead. > > Change-Id: Ic542a64fcd88e31ae2aad6feff1da278c7086891 > > I think this chage simplifies the code and I can confirm this change causes no regressions on aarch64 Fedora_Rawhide. Thanks, I'll add your Reviewed-By for patches 1 and 2. Simon