From: Pedro Alves <palves@redhat.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Cc: Yao Qi <qiyaoltc@gmail.com>
Subject: Re: [PATCHv2 2/2] gdb: Make some test names unique
Date: Thu, 13 Jul 2017 22:40:00 -0000 [thread overview]
Message-ID: <975f251d-36db-6e69-6435-6be598628077@redhat.com> (raw)
In-Reply-To: <20170713201511.GH27353@embecosm.com>
On 07/13/2017 09:15 PM, Andrew Burgess wrote:
> Thanks for the review and feedback. I've taken on-board what you both
> said, and I have a new patch which I think should be fine, in this I:
>
> - Add '(...text...)' at the end, but only _without_ a space before
> the '('.
>
> - I no longer use line numbers to make test names unique, instead I
> use more descriptive text.
>
> - I've not changed the names of any tests that were already unique,
> even if those names included a line number.
>
> OK to apply?
OK.
Though I'd think avoiding ()s entirely in the cases that the
()s are not part of the expression would be less surprising,
like e.g.:
-"evaluate filled vla(contents modified)"
+"evaluate filled vla, contents modified"
OK with that change too.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-07-13 22:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 18:57 [PATCH 0/2] Couple of small fixes to gdb.mi/mi-vla-fortran.exp test Andrew Burgess
2017-06-14 18:58 ` [PATCH 2/2] gdb: Make some test names unique Andrew Burgess
2017-06-22 10:37 ` Yao Qi
2017-06-22 11:08 ` Pedro Alves
2017-06-22 11:59 ` Yao Qi
2017-06-22 12:06 ` Pedro Alves
2017-06-22 12:12 ` Pedro Alves
2017-07-13 20:15 ` [PATCHv2 " Andrew Burgess
2017-07-13 22:40 ` Pedro Alves [this message]
2017-06-14 18:58 ` [PATCH 1/2] gdb: Fix parameter passing to mi_create_breakpoint Andrew Burgess
2017-06-22 10:16 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=975f251d-36db-6e69-6435-6be598628077@redhat.com \
--to=palves@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).