public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <palves@redhat.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Add selftests run filtering
Date: Wed, 06 Sep 2017 18:44:00 -0000	[thread overview]
Message-ID: <97798d29959f571b9718251b17a30408@polymtl.ca> (raw)
In-Reply-To: <6ad827ae97e146194f5f644fb35b320e@polymtl.ca>

On 2017-09-06 20:41, Simon Marchi wrote:
> On 2017-09-06 20:37, Simon Marchi wrote:
>> On 2017-09-06 17:25, Pedro Alves wrote:
>>> Sounds useful.
>>> 
>>> Patch looks fine to me.  Nits and comments below.
>>> 
>>> I wonder whether we'll want to be able to do select tests
>>> with e.g., a regexp instead of exact matching.  If we do, then
>>> the std::vector->std::map change would seem pointless.
>> 
>> Not sure I understand.  I am not using exact matching now either, so
>> using a map is probably already pointless.  I am not sure what lead me
>> there, maybe I started with the intent of using exact matching.  I'll
>> change it to a vector of a new struct type.
> 
> Ah, now I remember.  It was so we could easily check that there isn't
> already a test with this name, when registering a new test.  It's
> won't break anything if we happened to have two tests with the same
> name, so I can just remove this check.

Oh, and also so it would automatically iterate in alphabetical order, I 
thought it was prettier :).

  reply	other threads:[~2017-09-06 18:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-05 11:51 Simon Marchi
2017-09-06 15:25 ` Pedro Alves
2017-09-06 18:38   ` Simon Marchi
2017-09-06 18:41     ` Simon Marchi
2017-09-06 18:44       ` Simon Marchi [this message]
2017-09-06 18:49         ` Pedro Alves
2017-09-06 21:21   ` [PATCH v2] " Simon Marchi
2017-09-07 15:09     ` Simon Marchi
2017-09-07 15:11       ` [PATCH v3] " Simon Marchi
2017-09-16 12:08         ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97798d29959f571b9718251b17a30408@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).