From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Avoid -Wduplicated-cond warnings in gdb/python
Date: Thu, 15 Sep 2016 15:21:00 -0000 [thread overview]
Message-ID: <978cae40-3bbf-57f0-897b-77974a1df553@redhat.com> (raw)
In-Reply-To: <87bmzzptfl.fsf@tromey.com>
On 09/07/2016 05:26 PM, Tom Tromey wrote:
>>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
>
> Tom> I tried building gdb with -Wduplicated-cond. This patch fixes the
> Tom> simpler issue that was found.
>
> [...]
>
> Tom> 2016-07-21 Tom Tromey <tom@tromey.com>
>
> Tom> * python/py-value.c (convert_value_from_python): Make PyInt_Check
> Tom> conditional on Python 2.
> Tom> * python/py-arch.c (archpy_disassemble): Make PyInt_Check
> Tom> conditional on Python 2.
>
> Ping.
> I realized today that this was never reviewed.
This is OK. I'd be totally fine with you self approving
this...
Thanks,
Pedro Alves
prev parent reply other threads:[~2016-09-15 15:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 19:48 Tom Tromey
2016-09-07 16:44 ` Tom Tromey
2016-09-15 15:21 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=978cae40-3bbf-57f0-897b-77974a1df553@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).