From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 23B153858425 for ; Tue, 18 Apr 2023 12:43:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 23B153858425 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0882221A8D; Tue, 18 Apr 2023 12:43:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1681821836; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5BkEqHmxbTsZzx8+sbNiY1Py/jXUlI3geEgzroasdXs=; b=r1clsH/IAEfcjn2/FGSxqhuUJwhkKHgWBtERkP/yQjB3P6Nr6TkfDnoYEYx9zNZ4F+CAvA IwkX0mnJAwTz80P9xIzPhYj4R5csNrX70A1seIsJRzXheplacePmzu+68gmSH1AdOIgZd4 rqujMODV9HQ8dRjNw2eF5wIRcRfyA+k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1681821836; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5BkEqHmxbTsZzx8+sbNiY1Py/jXUlI3geEgzroasdXs=; b=xf1CMLgMoLM1vBub2zwyGh0ifi4UXSlnZwwJlVneL3XkPdG3GS1NjuXGJ0Ej3uYDrdMWAl XJp0aEx6UK1UUWBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E2C2E139EC; Tue, 18 Apr 2023 12:43:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 96M1NouQPmRZHAAAMHmgww (envelope-from ); Tue, 18 Apr 2023 12:43:55 +0000 Message-ID: <97c65614-e1a5-a9cb-b5a3-36020e8ed259@suse.de> Date: Tue, 18 Apr 2023 14:43:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 1/1] [gdb/contrib] Add make-check-all.sh Content-Language: en-US To: gdb-patches@sourceware.org, Simon Marchi References: <20230403150957.28921-1-tdevries@suse.de> <20230403150957.28921-2-tdevries@suse.de> <87wn2rc22u.fsf@redhat.com> Cc: Andrew Burgess From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/5/23 11:01, Tom de Vries via Gdb-patches wrote: > On 4/4/23 13:35, Andrew Burgess wrote: >> Tom de Vries via Gdb-patches writes: >> >>> Add script gdb/contrib/make-check-all.sh, that's intended to function >>> as a >>> drop-in replacement of make check, but excercising all host/target >>> boards in >>> gdb/testsuite/boards. >>> >>> Shell-checked and tested on x86_64-linux. >> >> Hi Tom, >> >> Thanks for putting this together, I think this could be really useful. >> > > That's great to hear :) > >> I'm not a fan of the way you've split the patch description into email >> 0/1 and not included it with this commit.  I think there's lots of >> useful information in there, and I'd much rather have the whole >> description included in the commit message -- it's much easier to find >> then rather than having to hunt on the mailing list in the future. >> > > Ack, I've reworked this into a patch rather than patch series. > >>> --- >>>   gdb/contrib/make-check-all.sh | 255 ++++++++++++++++++++++++++++++++++ >>>   1 file changed, 255 insertions(+) >>>   create mode 100755 gdb/contrib/make-check-all.sh >>> >>> diff --git a/gdb/contrib/make-check-all.sh >>> b/gdb/contrib/make-check-all.sh >>> new file mode 100755 >>> index 00000000000..1befe418b81 >>> --- /dev/null >>> +++ b/gdb/contrib/make-check-all.sh >>> @@ -0,0 +1,255 @@ >>> +#!/bin/bash >>> + >>> +# Copyright (C) 2023 Free Software Foundation, Inc. >>> +# This program is free software; you can redistribute it and/or modify >>> +# it under the terms of the GNU General Public License as published by >>> +# the Free Software Foundation; either version 3 of the License, or >>> +# (at your option) any later version. >>> +# >>> +# This program is distributed in the hope that it will be useful, >>> +# but WITHOUT ANY WARRANTY; without even the implied warranty of >>> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the >>> +# GNU General Public License for more details. >>> +# >>> +# You should have received a copy of the GNU General Public License >>> +# along with this program.  If not, see . >>> + >>> +# Run make check with all boards from gdb/testsuite/boards. >> >> I think you need some kind of usage test here too.  Imagine a new >> developer finds this file and looks inside.  Ideally, I think they >> should know how to use it, and what it will do for them without having >> to read any of the actual script content. >> > > Added. > >> On implementation, I wonder if it would be useful to provide a mechanism >> by which the gdb.sum and gdb.log files for each test run could be >> preserved? >> > > Done, I've renamed --keep to --keep-tmp, and added this new > functionality under --keep. > > I've also added "set -e" to make sure ^C aborts the script rather than > just one make check invocation, and moved the tmpdir removal to a > cleanup function that's executed on exit, to make sure ^C doesn't leave > tmpdirs behind. > I'd like to commit this at the end of the week, if there are no further review comments. Simon, I remember discussing something similar with you a few years ago ( https://sourceware.org/pipermail/gdb-patches/2020-May/169003.html ), so I wondered if you have any comments on this approach. Thanks, - Tom