From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by sourceware.org (Postfix) with ESMTPS id 621383857415 for ; Thu, 31 Mar 2022 19:25:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 621383857415 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f49.google.com with SMTP id n35so387188wms.5 for ; Thu, 31 Mar 2022 12:25:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=LWeeWDwQ2exTNtnICvPdlj5pjMkq/6yjD6HQDm0TaUs=; b=DaV4aNuma14LZgYA1Ct6As37Ub6VMcCPisAqTgncGTzI1bJzFI2PYL+wH8h9GTooP/ 7RoWcoXpDodv6lMR+42JUccg1vyjmy/NUyXuCzn10uu6V34qmg+cyB1SVlgvUBj7EJN7 jD20qN6vi/y/+Mdl6BxZEJZVU5UMvpPaV5oM/eEEoK+55YX/FKTh1Ef2SpO+8M2vDBLd IGd3pd9wjx0UvUzkM1j7DjaH06dBLNuSqyR76aUQtj7TfjXJquXSnrzjcgSpFz3wRK0K iNMzA7fM4m9AlwfV1+z65NZ8UPjA11bJ9msaobB/waI5J1sAm1YSgijlKeW5ZmXOi8uC xlBg== X-Gm-Message-State: AOAM531UcyIJXlbKLuuzp5YkSctTvNWQk8maRSWpxm6aoAdQwZaikaw2 4YcA/DoiPcgNtfKOySZzQ/9yzsj3nl8nGw== X-Google-Smtp-Source: ABdhPJwa32sWrRy2ZT8opWI3TSqLDatNU0GkUaD45Ei8q6XEe0kIWNA7sQIZVXuNnN5jQGu1LzLopg== X-Received: by 2002:a05:600c:4e4b:b0:38c:eebc:2ec4 with SMTP id e11-20020a05600c4e4b00b0038ceebc2ec4mr5969256wmq.47.1648754734435; Thu, 31 Mar 2022 12:25:34 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id m185-20020a1ca3c2000000b0038c836a5c13sm8112301wme.20.2022.03.31.12.25.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Mar 2022 12:25:33 -0700 (PDT) Message-ID: <97c790f7-a92c-d46a-713e-1fc810ce287d@palves.net> Date: Thu, 31 Mar 2022 20:25:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 8/9] gdb/remote: remove_new_fork_children don't access target_waitstatus::child_ptid if kind == TARGET_WAITKIND_THREAD_EXITED Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20220118040937.730282-1-simon.marchi@polymtl.ca> <20220118040937.730282-9-simon.marchi@polymtl.ca> From: Pedro Alves In-Reply-To: <20220118040937.730282-9-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2022 19:25:36 -0000 I thought I was done with this, but then I noticed there was a v2... > Indeed, the code accesses target_waitstatus::child_ptid when the kind > is TARGET_WAITKIND_THREAD_EXITED, which is not right. A > TARGET_WAITKIND_THREAD_EXITED event does not have a child_ptid value > associated, it has an exit status, which we are not interested in. The > intent is to remove from the thread list the thread that has exited. > Its ptid is found in the stop reply event, get it from there. Hmm, indeed. I think I'll need to tweak this in the step-over-exit work, though. Meanwhile, this is OK.