From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id 4DAF13858D32 for ; Thu, 10 Aug 2023 15:50:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4DAF13858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-3fe12820bffso9237875e9.3 for ; Thu, 10 Aug 2023 08:50:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691682606; x=1692287406; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bzWRg9t3NBeGgqD2frdxXgTFnImdvBvy/pZ8Bw5TM0Q=; b=YUPmdPy0avWTCLsih53YzXQ2G1REDZ5Dc3mL3EkCUcWOApcVO/tSU6Pe8xeA/Ou1rw uSA5cAfD0SXznfjMarb/GHFDrNuIOis9LPUa7hMuM4n7+7cTyg2Hkp4KrXgtPz0NVHU4 FKt0O4Rf0RIrJnz8aWgQVTXtg0wQO8IwpvylxGrItVci1FngJ5gjKXk4GkYDTi5cMZbI zLPbOETCcJULjJiPT/2ZBSWRCPNk+gwUZf9i3vo5WJMwT93o7N2+UAyI+b5B8wWNtQUW 8IuG4uT44dJDp3SIHfoQJ/l2hg785MJiUHSIrek2hTvVSCojVJMCWahptRRPeWYDZUQm OkJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691682606; x=1692287406; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bzWRg9t3NBeGgqD2frdxXgTFnImdvBvy/pZ8Bw5TM0Q=; b=YIk/XFESQomXoxm4CPrIY8VEHnlvUS36qkhNQOQWSIZvNEqPqOYD4a0ttLXV0VQFP4 4wP7EpXXlMa7goHGfGNkK+dLY9PIr+BkyndnezwGqHHv5sn3s1htnsW+hrg9aFCRCXp8 Dzm9KOkN2E1tajGhIIKgogVJIxt2PFpJ7B3b8x/h/ciuLrO3Qw6YfpeLdh1giFW9upNw B44nJUHysC9Dk9ESea3Mhj1L/GKV1pzZHhfBK95eQINNAfqF/E/bpI8TBBrJBg/Bnuba Dor0hqgz4ag4PZgQZcT69XR+a6BDrgW62rae1VhxB9HStRLk7qIBAeEqujyQmOvrpTMG +yhw== X-Gm-Message-State: AOJu0YwzFdzSlOGbl6+3zNcIDvpTpgSBPt0+yBEnZno+nEmiaSwJrRBm +ex1FpOFpC/HHRXNC3H2Awrhng== X-Google-Smtp-Source: AGHT+IGYKxvfnVLx2tEvZBQWdhrTj0bEbFmZH/mSmzSVoTYms2qQik6dKMN9s0OBWScmyhK/SUb0wA== X-Received: by 2002:a05:600c:3654:b0:3fb:403d:90c0 with SMTP id y20-20020a05600c365400b003fb403d90c0mr2226663wmq.39.1691682605963; Thu, 10 Aug 2023 08:50:05 -0700 (PDT) Received: from [192.168.69.115] (tre93-h02-176-184-7-255.dsl.sta.abo.bbox.fr. [176.184.7.255]) by smtp.gmail.com with ESMTPSA id n16-20020a5d6610000000b003179d5aee67sm2543434wru.94.2023.08.10.08.50.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Aug 2023 08:50:05 -0700 (PDT) Message-ID: <9816ed3e-28af-508c-62f6-b638827436c4@linaro.org> Date: Thu, 10 Aug 2023 17:50:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 8/8] gdbstub: don't complain about preemptive ACK chars Content-Language: en-US To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org Cc: Ilya Leoshkevich , Yonggang Luo , Beraldo Leal , Richard Henderson , Peter Maydell , Thomas Huth , David Hildenbrand , qemu-arm@nongnu.org, qemu-s390x@nongnu.org, Wainer dos Santos Moschetta , gdb-patches@sourceware.org References: <20230810153640.1879717-1-alex.bennee@linaro.org> <20230810153640.1879717-9-alex.bennee@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230810153640.1879717-9-alex.bennee@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/8/23 17:36, Alex Bennée wrote: > When starting a remote connection GDB sends an '+': > > /* Ack any packet which the remote side has already sent. */ > remote_serial_write ("+", 1); > > which gets flagged as a garbage character in the gdbstub state > machine. As gdb does send it out lets be permissive about the handling > so we can better see real issues. > > Signed-off-by: Alex Bennée > Cc: gdb-patches@sourceware.org > --- > gdbstub/gdbstub.c | 5 +++++ > 1 file changed, 5 insertions(+) Reviewed-by: Philippe Mathieu-Daudé