From: Tom de Vries <tdevries@suse.de>
To: Andrew Burgess <aburgess@redhat.com>, Simon Marchi <simark@simark.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCHv2 5/6] gdb: add assert in remote_target::wait relating to async being off
Date: Thu, 25 Nov 2021 12:36:07 +0100 [thread overview]
Message-ID: <98256892-d0a7-1332-cefe-2704e702179b@suse.de> (raw)
In-Reply-To: <20211125100458.GP2662946@redhat.com>
On 11/25/21 11:04 AM, Andrew Burgess via Gdb-patches wrote:
> * Simon Marchi <simark@simark.ca> [2021-11-24 16:23:30 -0500]:
>
>> On 2021-11-24 7:22 a.m., Andrew Burgess via Gdb-patches wrote:
>>> While working on another patch I ended up in a situation where I had
>>> async mode disabled (with 'maint set target-async off'), but the async
>>> event token got marked anyway.
>>>
>>> In this situation GDB was continually calling into
>>> remote_target::wait, however, the async token would never become
>>> unmarked as the unmarking is guarded by target_is_async_p.
>>>
>>> We could just unconditionally unmark the token, but that would feel
>>> like just ignoring a bug, so, instead, lets assert that if
>>> !target_is_async_p, then the async token should not be marked.
>>>
>>> This assertion would have caught my earlier mistake.
>>>
>>> There should be no user visible changes with this commit.
>>> ---
>>> gdb/remote.c | 6 +++++-
>>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/gdb/remote.c b/gdb/remote.c
>>> index 25a4d3cab6e..da8ed81ba78 100644
>>> --- a/gdb/remote.c
>>> +++ b/gdb/remote.c
>>> @@ -8309,9 +8309,13 @@ remote_target::wait (ptid_t ptid, struct target_waitstatus *status,
>>> remote_state *rs = get_remote_state ();
>>>
>>> /* Start by clearing the flag that asks for our wait method to be called,
>>> - we'll mark it again at the end if needed. */
>>> + we'll mark it again at the end if needed. If the target is not in
>>> + async mode then the async token should not be marked. */
>>> if (target_is_async_p ())
>>> clear_async_event_handler (rs->remote_async_inferior_event_token);
>>> + else
>>> + gdb_assert (!async_event_handler_marked
>>> + (rs->remote_async_inferior_event_token));
>>>
>>> ptid_t event_ptid;
>>>
>>> --
>>> 2.25.4
>>>
>>
>> LGTM.
>>
>> I think the series can be merged at least up to here, I think these are
>> good cleanups.
>
> Thanks, I made the change you suggested about one target_can_async_p
> function calling the other, and pushed patches 1 to 5.
>
I'm running into the assert:
https://sourceware.org/bugzilla/show_bug.cgi?id=28627 .
Thanks,
- Tom
> The final patch still pending.
>
> Thanks,
> Andrew
>
next prev parent reply other threads:[~2021-11-25 11:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 14:08 [PATCH 0/4] Improve 'maint set target-async off' for remote targets Andrew Burgess
2021-11-23 14:08 ` [PATCH 1/4] gdb: add asserts in target.c for target_async_permitted Andrew Burgess
2021-11-23 21:31 ` Simon Marchi
2021-11-23 14:08 ` [PATCH 2/4] gdb/remote: merge ::is_async_p and ::can_async_p methods Andrew Burgess
2021-11-23 21:33 ` Simon Marchi
2021-11-24 10:14 ` Andrew Burgess
2021-11-23 14:08 ` [PATCH 3/4] gdb: add assert in remote_target::wait relating to async being off Andrew Burgess
2021-11-23 21:50 ` Simon Marchi
2021-11-23 14:08 ` [PATCH 4/4] gdb/remote: some fixes for 'maint set target-async off' Andrew Burgess
2021-11-23 22:03 ` Simon Marchi
2021-11-23 16:39 ` [PATCH 0/4] Improve 'maint set target-async off' for remote targets John Baldwin
2021-11-24 12:22 ` [PATCHv2 0/6] " Andrew Burgess
2021-11-24 12:22 ` [PATCHv2 1/6] gdb: introduce a new overload of target_can_async_p Andrew Burgess
2021-11-24 12:22 ` [PATCHv2 2/6] gdb: hoist target_async_permitted checks into target.c Andrew Burgess
2021-11-24 21:17 ` Simon Marchi
2021-11-24 12:22 ` [PATCHv2 3/6] gdb: add asserts in target.c for target_async_permitted Andrew Burgess
2021-11-24 21:21 ` Simon Marchi
2021-11-24 12:22 ` [PATCHv2 4/6] gdb: simplify remote_target::is_async_p Andrew Burgess
2021-11-24 12:22 ` [PATCHv2 5/6] gdb: add assert in remote_target::wait relating to async being off Andrew Burgess
2021-11-24 21:23 ` Simon Marchi
2021-11-25 10:04 ` Andrew Burgess
2021-11-25 11:36 ` Tom de Vries [this message]
2021-11-25 13:46 ` Andrew Burgess
2021-11-25 14:17 ` Tom de Vries
2021-11-24 12:22 ` [PATCHv2 6/6] gdb/remote: some fixes for 'maint set target-async off' Andrew Burgess
2021-12-01 10:40 ` [PATCHv3 0/2] Improve 'maint set target-async off' for remote targets Andrew Burgess
2021-12-01 10:40 ` [PATCHv3 1/2] gdb/remote: some fixes for 'maint set target-async off' Andrew Burgess
2021-12-16 21:15 ` Pedro Alves
2021-12-17 13:35 ` Andrew Burgess
2021-12-17 14:05 ` Pedro Alves
2021-12-18 10:21 ` Andrew Burgess
2021-12-01 10:40 ` [PATCHv3 2/2] gdb: add assert in remote_target::wait relating to async being off Andrew Burgess
2021-12-16 21:16 ` Pedro Alves
2021-12-18 10:21 ` Andrew Burgess
2021-12-13 11:41 ` PING: [PATCHv3 0/2] Improve 'maint set target-async off' for remote targets Andrew Burgess
2021-12-13 17:20 ` John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98256892-d0a7-1332-cefe-2704e702179b@suse.de \
--to=tdevries@suse.de \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).