From: Pedro Alves <palves@redhat.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCHv6] gdb: Change how frames are selected for 'frame' and 'info frame'.
Date: Thu, 27 Sep 2018 20:58:00 -0000 [thread overview]
Message-ID: <982a3d55-f2ae-a9e9-8ca5-707cedc967fe@redhat.com> (raw)
In-Reply-To: <20180926230626.GN5952@embecosm.com>
On 09/27/2018 12:06 AM, Andrew Burgess wrote:> Thanks for the review.
>
> This revision makes the following changes:
>
> - Addresses the two small grammatical errors, and removes the random
> comment line in the testsuite.
>
> - Rewrites the get_new_address function in the testsuite so that is
> actually does what it says on the tin (in line with your
> suggestion).
>
> - Extends the header comment on parse_frame_specification. While
> doing this I realised that due to the way this function is now
> used it can be simplified a lot. We now only handle a single
> argument. I'd rather not start extending the existing MI
> interface with new features at this point, and I didn't think
> keeping the more complex parse_frame_specification around "just in
> case" was good practice.
>
> It's because of this last change that I've posted the patch for
> another review. I think the change is sensible (and the tests pass),
> but I wanted another opinion.
I agree. LGTM.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-09-27 20:58 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 16:58 [PATCHv2 0/2] Changes to frame selection Andrew Burgess
2018-05-08 16:58 ` [PATCHv2 1/2] gdb: Split func_command into two parts Andrew Burgess
2018-05-18 19:57 ` Pedro Alves
2018-05-21 15:52 ` Andrew Burgess
2018-05-21 16:06 ` Pedro Alves
2018-05-08 16:59 ` [PATCHv2 2/2] gdb: Change how frames are selected for 'frame' and 'info frame' Andrew Burgess
2018-05-11 15:44 ` Eli Zaretskii
2018-05-21 12:16 ` Andrew Burgess
2018-05-21 17:46 ` Eli Zaretskii
2018-06-05 18:53 ` Andrew Burgess
2018-06-05 21:16 ` Philippe Waroquiers
2018-06-06 8:22 ` Andrew Burgess
2018-06-06 14:56 ` Eli Zaretskii
2018-06-07 16:19 ` [PATCHv3] " Andrew Burgess
2018-06-29 12:23 ` Andrew Burgess
2018-07-17 15:58 ` [PATCHv4] " Andrew Burgess
2018-07-23 20:46 ` Philippe Waroquiers
2018-07-25 18:14 ` Andrew Burgess
2018-08-13 22:20 ` [PATCHv5_A 1/2] " Andrew Burgess
2018-08-13 22:20 ` [PATCHv5 0/2] " Andrew Burgess
2018-08-14 10:31 ` Philippe Waroquiers
2018-08-21 13:10 ` Joel Brobecker
2018-08-27 11:04 ` Andrew Burgess
2018-08-27 15:23 ` Eli Zaretskii
2018-08-28 8:43 ` Andrew Burgess
2018-08-28 9:08 ` Eli Zaretskii
2018-08-28 18:03 ` [PATCHv6] " Andrew Burgess
2018-08-28 18:20 ` Eli Zaretskii
2018-09-05 7:46 ` PING: " Andrew Burgess
2018-09-13 18:02 ` Pedro Alves
2018-09-18 23:01 ` Andrew Burgess
2018-09-19 16:26 ` Pedro Alves
2018-09-26 23:06 ` Andrew Burgess
2018-09-27 20:58 ` Pedro Alves [this message]
[not found] ` <cover.1534197765.git.andrew.burgess@embecosm.com>
2018-08-13 22:20 ` [PATCHv5_B 2/2] " Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=982a3d55-f2ae-a9e9-8ca5-707cedc967fe@redhat.com \
--to=palves@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).