From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83780 invoked by alias); 27 Sep 2018 20:58:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 83769 invoked by uid 89); 27 Sep 2018 20:58:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=sensible X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Sep 2018 20:58:35 +0000 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D99B23082A26; Thu, 27 Sep 2018 20:58:33 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id BD26A2010D5A; Thu, 27 Sep 2018 20:58:32 +0000 (UTC) Subject: Re: [PATCHv6] gdb: Change how frames are selected for 'frame' and 'info frame'. To: Andrew Burgess References: <837eka504x.fsf@gnu.org> <20180828180327.30992-1-andrew.burgess@embecosm.com> <6c29729c-13d6-3943-8637-65217d543fcf@redhat.com> <20180918230128.GS5952@embecosm.com> <20180926230626.GN5952@embecosm.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <982a3d55-f2ae-a9e9-8ca5-707cedc967fe@redhat.com> Date: Thu, 27 Sep 2018 20:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180926230626.GN5952@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-09/txt/msg00882.txt.bz2 On 09/27/2018 12:06 AM, Andrew Burgess wrote:> Thanks for the review. > > This revision makes the following changes: > > - Addresses the two small grammatical errors, and removes the random > comment line in the testsuite. > > - Rewrites the get_new_address function in the testsuite so that is > actually does what it says on the tin (in line with your > suggestion). > > - Extends the header comment on parse_frame_specification. While > doing this I realised that due to the way this function is now > used it can be simplified a lot. We now only handle a single > argument. I'd rather not start extending the existing MI > interface with new features at this point, and I didn't think > keeping the more complex parse_frame_specification around "just in > case" was good practice. > > It's because of this last change that I've posted the patch for > another review. I think the change is sensible (and the tests pass), > but I wanted another opinion. I agree. LGTM. Thanks, Pedro Alves