From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 04A703858C41 for ; Tue, 8 Aug 2023 00:31:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 04A703858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 03B5B201A9; Tue, 8 Aug 2023 00:31:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1691454677; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ERzk4laKp86yoOzgnJcinhINwsJ6RS13YvcDafAjr5k=; b=ihYuTnb2zZHVRPaQx3JAuIlmf3BwVIJOEpc4nazxzY//8A6j0xQNpKL9X3Hf8P7MYwyVis 8u+zebeTINLqlBdvEbcc/idGbMkzLEcJqX2Y19ZAcixTQo/OkGNYL5EcIb6gt/L7LP2g/h 7fBrk9uQAcS2BQWnzDyZHeJcmlT7Wn4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1691454677; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ERzk4laKp86yoOzgnJcinhINwsJ6RS13YvcDafAjr5k=; b=R62UKB+PXejsX/UyGYnmz96Up2l5ulFSG5CwmHH2iWj21s/3K/vdN5ng5k21gjSQgrmW5+ ZdscN/EadGLsvQCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DCFCB13451; Tue, 8 Aug 2023 00:31:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ZMC1NNSM0WSuQQAAMHmgww (envelope-from ); Tue, 08 Aug 2023 00:31:16 +0000 Content-Type: multipart/mixed; boundary="------------0NnTzrkeSN6V4i1bx3NRNdXE" Message-ID: <9863d400-87aa-f31e-ac49-f2ef2b5011b3@suse.de> Date: Tue, 8 Aug 2023 02:30:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/build] Fix build breaker with -std=c++11 Content-Language: en-US To: Tom Tromey , Simon Marchi Cc: Tom de Vries via Gdb-patches References: <20230806235915.18746-1-tdevries@suse.de> <51561E9D-24F0-48CB-A563-50F29C2966D9@polymtl.ca> <87r0oe7b2k.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87r0oe7b2k.fsf@tromey.com> X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------0NnTzrkeSN6V4i1bx3NRNdXE Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/8/23 00:16, Tom Tromey wrote: > Simon> When we encounter things like this, should we add some greppable > Simon> TODO comment to record an actionable item for when we switch to a > Simon> more recent C++ version? > > FWIW I know of one other instance of this, in gdb_demangle: > > std::string copy = name; > run_on_main_thread ([=] () > { > report_failed_demangle (copy.c_str (), core_dump_allowed, > > Here, the name is copied twice, but with move captures there could be > just a single copy. Like so? Thanks, - Tom --------------0NnTzrkeSN6V4i1bx3NRNdXE Content-Type: text/x-patch; charset=UTF-8; name="0001-gdb-build-Use-move-capture-in-gdb_demangle.patch" Content-Disposition: attachment; filename="0001-gdb-build-Use-move-capture-in-gdb_demangle.patch" Content-Transfer-Encoding: base64 RnJvbSA3YTZmM2U3ZTM5NzAxYjJiMGUyZjNiOGY3NjFlN2MzMmY0NmFmNGE2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBUb20gZGUgVnJpZXMgPHRkZXZyaWVzQHN1c2UuZGU+ CkRhdGU6IFR1ZSwgOCBBdWcgMjAyMyAwMTozNDo0NSArMDIwMApTdWJqZWN0OiBbUEFUQ0hd IFtnZGIvYnVpbGRdIFVzZSBtb3ZlIGNhcHR1cmUgaW4gZ2RiX2RlbWFuZ2xlCgpVc2UgbW92 ZSBjYXB0dXJlIGluIGdkYl9kZW1hbmdsZSB3aGVuIGNvbXBpbGluZyBmb3IgYysrMTQgb3Ig aGlnaGVyLCB0byBzYXZlIGEKc3RkOjpzdHJpbmcgY29weS4KClRlc3RlZCBvbiB4ODZfNjQt bGludXguCgpSZXBvcnRlZC1CeTogVG9tIFRyb21leSA8dG9tQHRyb21leS5jb20+Ci0tLQog Z2RiL2NwLXN1cHBvcnQuYyB8IDggKysrKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2Vy dGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9nZGIvY3Atc3VwcG9ydC5j IGIvZ2RiL2NwLXN1cHBvcnQuYwppbmRleCAyZmI5ZDllZjBiMi4uMDMwMDcyNzQzNGQgMTAw NjQ0Ci0tLSBhL2dkYi9jcC1zdXBwb3J0LmMKKysrIGIvZ2RiL2NwLXN1cHBvcnQuYwpAQCAt MTY1Niw3ICsxNjU2LDEzIEBAIGdkYl9kZW1hbmdsZSAoY29uc3QgY2hhciAqbmFtZSwgaW50 IG9wdGlvbnMpCiAJICAgICB3ZSBtaWdodCBiZSBpbiBhIGJhY2tncm91bmQgdGhyZWFkLiAg SW5zdGVhZCwgYXJyYW5nZSBmb3IKIAkgICAgIHRoZSByZXBvcnRpbmcgdG8gaGFwcGVuIG9u IHRoZSBtYWluIHRocmVhZC4gICovCiAJICBzdGQ6OnN0cmluZyBjb3B5ID0gbmFtZTsKLQkg IHJ1bl9vbl9tYWluX3RocmVhZCAoWz1dICgpCisJICBydW5fb25fbWFpbl90aHJlYWQgKFsK KyNpZiBfX2NwbHVzcGx1cyA+PSAyMDE0MDJMCisJCQkgICAgICAgPSwgY29weSA9IHN0ZDo6 bW92ZSAoY29weSkKKyNlbHNlCisJCQkgICAgICAgPQorI2VuZGlmCisJCQkgICAgICAgXSAo KQogCSAgICB7CiAJICAgICAgcmVwb3J0X2ZhaWxlZF9kZW1hbmdsZSAoY29weS5jX3N0ciAo KSwgY29yZV9kdW1wX2FsbG93ZWQsCiAJCQkJICAgICAgY3Jhc2hfc2lnbmFsKTsKCmJhc2Ut Y29tbWl0OiBkZGJlOGMzYzhhODY2NWU3N2Y5ZWJiMTA4YzU2MjdhNmViZWNiODFmCi0tIAoy LjM1LjMKCg== --------------0NnTzrkeSN6V4i1bx3NRNdXE--