From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61674 invoked by alias); 10 Jul 2018 04:38:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 61665 invoked by uid 89); 10 Jul 2018 04:38:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Jul 2018 04:38:39 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 3FE511E059; Tue, 10 Jul 2018 00:38:38 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531197518; bh=Rs5xAVhYD/3fv+nJxyYhPVM8qBiXLQUb3WPebvRiF5E=; h=Subject:To:References:From:Date:In-Reply-To:From; b=bLJUShqLUzPkJQaNBuMYkI/nJ1Nraa3HaQSCBl+l1+2Hf3VtJTmlMZ47AHvKl29rL 7RmcQ8P4jhK303Fv5L7r8Wj2RfO6RPq9W2pTLi0DZfxAlVVfICzdQ6ZAP743Xbkv+A l2GTdVOjBwTc2tvdft1Up5eGI5Ig+aaC2/LUa3Uk= Subject: Re: [RFA 42/42] Remove record_line_ftype To: Tom Tromey , gdb-patches@sourceware.org References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-43-tom@tromey.com> From: Simon Marchi Message-ID: <9875392b-e9f2-bbb6-a41e-5d6a4384d68d@simark.ca> Date: Tue, 10 Jul 2018 04:38:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180523045851.11660-43-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00260.txt.bz2 On 2018-05-23 12:58 AM, Tom Tromey wrote: > The record_line_ftype typedef was only used in the DWARF reader, and > we removed those uses a few patches ago. So, remove the typedef. LGTM. Simon PS: Thanks for splitting the series the way you did. 42 patches looks like a lot, but it was actually much easier to understand and review like this than if it had been 4-5 big patches.