From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tiezhu Yang <yangtiezhu@loongson.cn>,
Pedro Alves <pedro@palves.net>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v3 2/4] gdb: testsuite: add new gdb_attach to check "attach" command
Date: Fri, 18 Mar 2022 14:23:12 -0400 [thread overview]
Message-ID: <98853a0a-4da0-bde5-fe11-640664742474@polymtl.ca> (raw)
In-Reply-To: <eaa3ae50-ff63-c225-1523-b6c4cb56f997@loongson.cn>
> (1) parse_options
> gdb/testsuite/lib/gdb.exp
> proc gdb_attach { testpid {options {}} } {
> parse_options {
> {pattern ""}
> }
>
> gdb_test_multiple "attach $testpid" "attach" {
> -re -wrap "Attaching to.*ptrace: Operation not permitted\\." {
> unsupported "$gdb_test_name (Operation not permitted)"
> return 0
> }
> -re -wrap "$pattern" {
> pass $gdb_test_name
> return 1
> }
> }
> }
>
> gdb/testsuite/gdb.base/attach-pie-noexec.exp
> if { ![gdb_attach $testpid] } {
> kill_wait_spawned_process $test_spawn_id
> return
> }
>
> gdb/testsuite/gdb.base/jit-elf.exp
> set attach_opts {
> "pattern" "main.*at .*$::main_srcfile:.*"
> }
>
> if { ![gdb_attach $testpid $attach_opts] } {
> return 0
> }
>
> (2) parse_args
> gdb/testsuite/lib/gdb.exp
> proc gdb_attach { testpid args } {
> parse_args {
> {pattern ""}
> }
>
> if { [llength $args] != 0 } {
> error "Unexpected arguments: $args"
> }
>
> gdb_test_multiple "attach $testpid" "attach" {
> -re -wrap "Attaching to.*ptrace: Operation not permitted\\." {
> unsupported "$gdb_test_name (Operation not permitted)"
> return 0
> }
> -re -wrap "$pattern" {
> pass $gdb_test_name
> return 1
> }
> }
> }
>
> gdb/testsuite/gdb.base/attach-pie-noexec.exp
> if { ![gdb_attach $testpid] } {
> kill_wait_spawned_process $test_spawn_id
> return
> }
>
> gdb/testsuite/gdb.base/jit-elf.exp
> if { ![gdb_attach $testpid \
> -pattern "main.*at .*$::main_srcfile:.*"] } {
> return 0
> }
>
> I will wait for your feedback and then send v4 later.
Go with parse_args (the version Pedro suggested).
Thanks,
Simon
next prev parent reply other threads:[~2022-03-18 18:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 14:00 [PATCH v3 0/4] gdb: add gdb_attach to fix failed testcases Tiezhu Yang
2022-03-17 14:00 ` [PATCH v3 1/4] gdb: testsuite: remove attach test from can_spawn_for_attach Tiezhu Yang
2022-03-17 14:00 ` [PATCH v3 2/4] gdb: testsuite: add new gdb_attach to check "attach" command Tiezhu Yang
2022-03-17 16:50 ` Pedro Alves
2022-03-17 17:04 ` Simon Marchi
2022-03-17 17:31 ` Pedro Alves
2022-03-18 1:56 ` Tiezhu Yang
2022-03-18 18:23 ` Simon Marchi [this message]
2022-03-17 14:01 ` [PATCH v3 3/4] gdb: testsuite: use gdb_attach to fix attach-pie-noexec.exp Tiezhu Yang
2022-03-17 16:51 ` Pedro Alves
2022-03-17 14:01 ` [PATCH v3 4/4] gdb: testsuite: use gdb_attach to fix jit-elf.exp Tiezhu Yang
2022-03-17 16:55 ` [PATCH v3 0/4] gdb: add gdb_attach to fix failed testcases Pedro Alves
2022-03-18 1:53 ` Tiezhu Yang
2022-03-18 18:33 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98853a0a-4da0-bde5-fe11-640664742474@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).