From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id B30643858D39 for ; Thu, 22 Feb 2024 19:58:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B30643858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B30643858D39 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2610:1c1:1:606c::19:2 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1708631887; cv=pass; b=sYJP8RNE6/oJgBvw10FuXuG0LWt/ymj+1MASIxke/MKDa6B0d74joYmCnTENt5emTlLuVSA2KQPlFacVEICQyro/WRmv1ISopXzF/t3RxPWVRl5iySAYwZldMUwKTRwUdjl1ibeyXQBVk8VNdEVj+xJYW1lZs0wSy6TNB5/8Asw= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1708631887; c=relaxed/simple; bh=mf9vJsH3dWB5p1jEfcQAFnWWMD98bOsmBIwQS3S8B8k=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=MFKy+uLeqA745oG0L8NSd5lHKpZZ4CerFBXSI9nyw9QxPlmnCGp6YCtzeM7JIC/jcpO83JewM8DU41DiuVrF+3qzfd1UutPZ7hSiBUJ0lwfGuC2SwvKJDS2QHk2NA1J0SRSssyQf/IeeyU6uwZF6YtY+ug8ly3XgVdXQDD5+o7s= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4TgkTV2t0wz4BwJ; Thu, 22 Feb 2024 19:58:06 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TgkTV0Wvmz4qx1; Thu, 22 Feb 2024 19:58:06 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708631886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rZ3MjtQGnltv1bicnCwpHv0qIhnlTI0indiJeHmwBZ0=; b=llpWKkjLGyWrgz/wWoCrPAw30S1Ti/VgpWolFa9QEB+m+DcOEFfBQvieRakfL+SwZk4xpK WyUO+q7itKsfm7/YQmvJJR+DlvkUUJ0LFeccPDizCHl/RK7xxEcrdAYCo0j9uamVEmSJF/ n1sE1cEZDvFr38/c2S8ZeMA7VsNMUoAVizztF57HISv9VibI8S3fqdZKEbA2NGN0t02r4i S30L4gMpmRP6PPBdnfsQgj931jXKQ0EH8N54PTHYlS7xOA4WwDmkhv/ZX2n0ZOqQPsit2q dfC+Owni1XFm5Urbq6vhCHHsDJA8QsSDW1tkDtL1ABnUkPoKLEX61BokjMa9tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708631886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rZ3MjtQGnltv1bicnCwpHv0qIhnlTI0indiJeHmwBZ0=; b=V9/ZHweaQcpy7S41bNkdAjmcSKYNEWUsVN1YamkWR1bAepcWMcenaUbqXC1CPMH8PAsjvr zTfYeXSFjor6XCM3/PHDXEKcirgKwysj6jMyCD42WUEiS3BW5rtSLfiKbEJlXvEhhGyHml cRb7UYj1av3lN9hyK0+1z1xoWANfto0WrVhU7dVYNzXUALtTXoBEtEXgmhkeKP/YTfcpgv b16AvENkQlYdnn63bRghV4hrrroq6Ji/CzjvzZ++l8MjZjvjhqxYPmtpZgLNKTZEI8TzgA JR08ZiDTLXIobsmc9lsA4RAec+T/FwH9FpSDCfMX8mFxQdIRXOFlzj2gC/yznA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708631886; a=rsa-sha256; cv=none; b=o4RqVHIraJTQhztdCS1TE+8KTBpOhpDG9xNRWS8/VZXFXSloI8kIB0TKuqQL54QHb24bnG CUPHSbemp1YCEyFyeGjhGU6uAD0mfauqMmvlqx9yaHhkHcONSulN6iJweQ1EMmcY2yKrfj ZDVx0S5UCWM9j5fnF3Lqa+gDyURLIVfNb+qdgMWGB2A8NCfvwz23C50zfu9UVhqni7zd1M tnvzfKn/ZIrtH1gX6QDpwWvfCFEI/CCfV3tyiF6+vP64PVXSgZ6QX9ht0k+WOaLha3S3hh v94Bu6sAHB72xwdkp/+nSlO7FyWDqfSHWPbP9nfXDIM+ntB+yqLrOx/zvkCNZQ== Received: from [IPV6:2601:644:937f:4c50:681d:ce08:338e:5fa0] (unknown [IPv6:2601:644:937f:4c50:681d:ce08:338e:5fa0]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4TgkTT4nBczL7r; Thu, 22 Feb 2024 19:58:05 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <98b6a85d-b720-4ac8-b77e-56858ca98ef3@FreeBSD.org> Date: Thu, 22 Feb 2024 11:58:04 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Use bool in dynamic type code Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20240206172441.3439889-1-tromey@adacore.com> From: John Baldwin In-Reply-To: <20240206172441.3439889-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/6/24 9:24 AM, Tom Tromey wrote: > This changes some of the dynamic-type-related code to use bool rather > than int. > > Regression tested on x86-64 Fedora 38. LGTM. My only thought about bool arguments is that often times just 'true/false' is not always intuitive at the call sites. The old code was just as bad (worse even) with 1/0. Approved-By: John Baldwin -- John Baldwin