Re: [PATCH] gdb/testsuite: make gdb.reverse/i386-avx-reverse.exp require avx

[Guinevere Larsen <guinevere@redhat.com>]

On 12/3/24 1:00 PM, Andrew Burgess wrote:
> Guinevere Larsen <guinevere@redhat.com> writes:
>
>> The test gdb.reverse/i386-avx-reverse.exp was assuming that if the CPU
>> was like x86, it would have AVX instructions because I didn't know how
>> to check for AVX instruction support explicitly.  This commit updates
>> that to use the pre-existing TCL proc have_avx.
>>
>> Also update the commet at the top of the test, since it was a copy of a
> typo: 'comment'
>
> With that fixed:
>
> Approved-By: Andrew Burgess <aburgess@redhat.com>
Fixed and pushed, thanks!

-- 
Cheers,
Guinevere Larsen
She/Her/Hers

>
> Thanks,
> Andrew
>
>
>> different test.
>> ---
>>   gdb/testsuite/gdb.reverse/i386-avx-reverse.exp | 9 +++------
>>   1 file changed, 3 insertions(+), 6 deletions(-)
>>
>> diff --git a/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp b/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp
>> index 6d8990067f2..cc920d3a2f3 100644
>> --- a/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp
>> +++ b/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp
>> @@ -16,15 +16,12 @@
>>   # This file is part of the gdb testsuite.
>>   
>>   #
>> -# This test tests some i386 general instructions for reverse execution.
>> +# This test tests i386 AVX instructions for reverse execution.  This
>> +# is supposed to test all supported instructions eventually.
>>   #
>>   
>>   require supports_reverse
>> -
>> -if {![istarget "*86*-*linux*"]} {
>> -    verbose "Skipping i386 reverse tests."
>> -    return
>> -}
>> +require have_avx
>>   
>>   # TODO: this is the case because I used xmm15 all over the test.
>>   # Some parts of the test require xmm15 to validate some code paths, but
>> -- 
>> 2.47.0