From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 8CDEB3858D3C for ; Tue, 3 Dec 2024 18:18:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8CDEB3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8CDEB3858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733249894; cv=none; b=TzngHWZRudOq7hB3v5jEsh9MkkT8SrbvZwHS8f7U2yKScxhnV2a7NqaxmrADPlNEQ3tgoPUtH2P85SWSGnOuK69ESgMtpZ03u3hrKtxZVznIRzpZBfxT2CT1KAdwyX5Y7AQxXEu07T/sDwrXaWFyQAvo3jIZJZvqi59sBs4mQv8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733249894; c=relaxed/simple; bh=5usACKtFXtHsY5+bGOzErXZB5fNTzGEi0mGyzgSVgCk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=JrwOzTz/fwfVuFMg9dlxHy6KOYsDuTydxy4yXgTcEk/J1wQBfgN2dqIuCtcmtnBTT6fXEdQ8AwMDlPbECT7SGnVJ0yPZ/sJ8gBY2/zJnck4WMVlv/qxzqTIIPtw3dcr9/1IiDQdccMtxVAhhuw2ahdsE6rj0c5qlTBj6kKWq/Yg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8CDEB3858D3C Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=DLJtpIkW DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733249894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7N45FPmCW+EXx7A4mUJCdzdnkOyf2IArjITVIbGcD8Q=; b=DLJtpIkW/s90fO18U5yBcPvTJlhAQsrH0LyLaFfzdfxgYugWOM4Aqe02q+S8pTczdx00l1 1wgmzyAwz63R+dLVvMQELewPYP6jKhH8ZA3rA/TkdWB7bQqvgQ3/qBrNuqGxcCZHy7Zfri lLoCeTMzG1KwZjNCaP6M66/adM0NRpQ= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-175-6z2zNEWDPQmOdBpfqWpZ0g-1; Tue, 03 Dec 2024 13:18:13 -0500 X-MC-Unique: 6z2zNEWDPQmOdBpfqWpZ0g-1 X-Mimecast-MFC-AGG-ID: 6z2zNEWDPQmOdBpfqWpZ0g Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-215ce620278so2924155ad.1 for ; Tue, 03 Dec 2024 10:18:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733249892; x=1733854692; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7N45FPmCW+EXx7A4mUJCdzdnkOyf2IArjITVIbGcD8Q=; b=MEDlVmt5/gCstOcB5aF/t203rj/TADMB7447vc5NOfDOb1eVM5/KFiYT8G2mwEzJuy OR18HFXe5FvGpqhttjapOM7DgTk6dwALYpI/E56hXJBq9G3AUqZQxpmaeCETow3xYFaU V7pN91qleoxeKJIhBQXX7NOZj9/PvF+c5ZhFlSQWt4gYCoOy+ndaSec+dtmNZeB+cltU fplKy5judcawQaPkS6gd1zTNEbLrPrJXpRT9xJAnPeB98fieg8vz+Tap4dMiqN6lVor8 ExzLws+YNqalnzCnCoVirPNkOQHcg5gYDFN60Qb8qjWGUSLiLlxT4tOG4e9ysFxeIC/E rNRw== X-Forwarded-Encrypted: i=1; AJvYcCUpl8n3+rSm5y+6CA8xFZRU1F6t2g18r5pz5LYrfABsQ5nI/Nb41OGaZ88VrCdoN76J5Ck3C9fYjKkdCA==@sourceware.org X-Gm-Message-State: AOJu0YzmLk5dEdHESnNZMZjWa26mQyWQZQALjsm47jrs/MmZmGfajPnA 5Fe+raSF2g3eJQ+nwUyn/Nx/PbR1oWR3+Bd9nTNnQqk2oFflkoeOe/khyXhjQkkM0ptaxaifA50 JP2zDSY8b/enPn5rQB52BPevnZ57ApAiZTUH3PCyOlBr+gvTtRJIgSO4VY7I= X-Gm-Gg: ASbGncv8DOM9XGn+fCN55ww82LT2EmfwUk+WomQQdbxq/GS5cBYS5gD3KN+5sLlMxJ1 +0xQuJYk92V5r8pL/BohtRJAturzX8XDk+TDL4tF4jwX4QYpuSyC/Yja268PppoOIZzb/wFC6P9 iSjCsGEZF23zLoy+fgW/2APRW0C/otTF5uxzuJ7dsz+1nD2jWyg129PM2Fme5ema5qt0msRDfqA oj8vDxdG93wabIUD0LvG3PMSNekaDzivrlBXVZnGYbmpABHA0DFjZaK8koQkg== X-Received: by 2002:a17:902:e801:b0:215:ac55:fd72 with SMTP id d9443c01a7336-215d00b96ecmr19283445ad.37.1733249892052; Tue, 03 Dec 2024 10:18:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IF3hUiLMuBxUjJXLtFH9yvJN4MwV3fT4jjLU8/d/+PMWNoR2UsuQqLQTNh1s1ZQycGHjGNQkQ== X-Received: by 2002:a17:902:e801:b0:215:ac55:fd72 with SMTP id d9443c01a7336-215d00b96ecmr19283225ad.37.1733249891752; Tue, 03 Dec 2024 10:18:11 -0800 (PST) Received: from ?IPV6:2804:14d:8084:92c5::1000? ([2804:14d:8084:92c5::1000]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2155be9b462sm63798735ad.157.2024.12.03.10.18.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Dec 2024 10:18:11 -0800 (PST) Message-ID: <98ddd5a2-802a-434c-be57-d7a7bd8b9c9e@redhat.com> Date: Tue, 3 Dec 2024 15:18:09 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite: make gdb.reverse/i386-avx-reverse.exp require avx To: Andrew Burgess , gdb-patches@sourceware.org References: <20241125175726.1012519-1-guinevere@redhat.com> <878qswkb93.fsf@redhat.com> From: Guinevere Larsen In-Reply-To: <878qswkb93.fsf@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: x60VonTDPMKY-qDUj6FP-tU5-ZzJeSFyq_SHgK34dGs_1733249892 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/3/24 1:00 PM, Andrew Burgess wrote: > Guinevere Larsen writes: > >> The test gdb.reverse/i386-avx-reverse.exp was assuming that if the CPU >> was like x86, it would have AVX instructions because I didn't know how >> to check for AVX instruction support explicitly. This commit updates >> that to use the pre-existing TCL proc have_avx. >> >> Also update the commet at the top of the test, since it was a copy of a > typo: 'comment' > > With that fixed: > > Approved-By: Andrew Burgess Fixed and pushed, thanks! -- Cheers, Guinevere Larsen She/Her/Hers > > Thanks, > Andrew > > >> different test. >> --- >> gdb/testsuite/gdb.reverse/i386-avx-reverse.exp | 9 +++------ >> 1 file changed, 3 insertions(+), 6 deletions(-) >> >> diff --git a/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp b/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp >> index 6d8990067f2..cc920d3a2f3 100644 >> --- a/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp >> +++ b/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp >> @@ -16,15 +16,12 @@ >> # This file is part of the gdb testsuite. >> >> # >> -# This test tests some i386 general instructions for reverse execution. >> +# This test tests i386 AVX instructions for reverse execution. This >> +# is supposed to test all supported instructions eventually. >> # >> >> require supports_reverse >> - >> -if {![istarget "*86*-*linux*"]} { >> - verbose "Skipping i386 reverse tests." >> - return >> -} >> +require have_avx >> >> # TODO: this is the case because I used xmm15 all over the test. >> # Some parts of the test require xmm15 to validate some code paths, but >> -- >> 2.47.0