From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simon.marchi@polymtl.ca>
Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11])
 by sourceware.org (Postfix) with ESMTPS id 776E83848038
 for <gdb-patches@sourceware.org>; Thu,  6 May 2021 02:02:27 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 776E83848038
Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0)
 by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 14622LMR009311
 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); 
 Wed, 5 May 2021 22:02:26 -0400
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 14622LMR009311
Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 46A211E813;
 Wed,  5 May 2021 22:02:21 -0400 (EDT)
Subject: Re: [PATCH 1/2] gdb/testsuite: resolve duplicate test names in
 gdb.guile/scm-breakpoint.exp
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
References: <cover.1620238156.git.andrew.burgess@embecosm.com>
 <e6905525c8a87ad15bc5229f4113640bb768c426.1620238156.git.andrew.burgess@embecosm.com>
From: Simon Marchi <simon.marchi@polymtl.ca>
Message-ID: <9915d2c1-4d11-b325-89cc-4bb1151b7e93@polymtl.ca>
Date: Wed, 5 May 2021 22:02:20 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <e6905525c8a87ad15bc5229f4113640bb768c426.1620238156.git.andrew.burgess@embecosm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 6 May 2021 02:02:21 +0000
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3,
 RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 06 May 2021 02:02:28 -0000

On 2021-05-05 2:10 p.m., Andrew Burgess wrote:
> Extend some test names to avoid duplicates.

LGTM.  If you'd like to clean this up further (push an obvious patch on
top of that), you could change all the:

proc foo { } {
    with_test_prefix foo {
	...
    }
}

To:

proc_with_prefix foo { } {
   ...
}

That would remove a level of indentation.

Simon