From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by sourceware.org (Postfix) with ESMTPS id 72B553858D38 for ; Wed, 21 Feb 2024 17:46:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 72B553858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 72B553858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708537606; cv=none; b=fIZcHTm7hIsHetUDTiHKpVqYt2CAKneyEVEAl7xrXOVrPk/tTFhY+Jz+p46rplKA6tlBtp+wQBpLT21S7Lrb5NnknC3FBqJlbP3tmnW8RJ2j0bKeV/f46NYvjmpGSoplt1cdnxbOz1rhp6A0Ypn9nQOLYSqItEnBVk9+bAzV7Lk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708537606; c=relaxed/simple; bh=VYfhzw9qb6rEUkrrQxZbZ6uKvuP6FIYc6i6makwLkiM=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=h2ZhUbGc9Yq9/ITYAa2bfaVFApFXh10ZPv0E5OXhWyjssDTsetN42kGtFTeED1yeUPWk5PI+aO1t0DnQRe7rBv4X4gYa7hHOSsVZuMi8xRnOLL0he2pKBfeotWovBTGbsBgX8lM9KM3THAXFY05ycdLoASiXQebicjbWYYsmfPI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4126f48411dso150605e9.0 for ; Wed, 21 Feb 2024 09:46:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708537604; x=1709142404; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nwdY3zuiYZ6q7TomUgg9ob0Sa/Phixh/93oODv3dZrY=; b=IuyzDpjYa/s83EYA9ekOO4U6CJFcIzRDQs3IaB84nwWcpe0fHoJhi/cagd5pLzVNtr /LtylPyU7l+VK63DkG8pvLWz4tu2OiUaptYEzmqNLwC950g22JJwkh5qEJHlpp8JyXGW TB3DHqPc1JeuYQgHduEeBrKrbeQaM1W7iB6NnwUZQm5aX7j3/UJ6EZNK0U+ZQ4EgJl15 nwY02j0+XxMc7qUufGvzKX/7p1nJw9VU8x5FfZ4Mtg1BDi8dyOFPrwJQ8vhSrAdMFtAi 1Jg7pzNfzeBEyAuQC9K7IPxcdQL+50IkcfrOUcTKmwQvlLXw54SU8nd7qZ5D25QgzCHj oumw== X-Gm-Message-State: AOJu0Ywj8CkYcxAocm5OK3YZY5U1dw5lor2IuYS9c0R0YylcBb22Dnpr kW6UvIlfYUJYEHfBwCRqOIzEtMC17eY4rGCoEJibxlq4zL4ar15ZgNzfc02d+XY= X-Google-Smtp-Source: AGHT+IE+VwExI20xDW62F1O/9Zt3OoWvwXzQw+VBzxNLBWEt4Dc30qMqeJljNlUnNkAmibUb3UfCBA== X-Received: by 2002:a05:600c:3549:b0:412:6e2d:66ee with SMTP id i9-20020a05600c354900b004126e2d66eemr245792wmq.0.1708537604116; Wed, 21 Feb 2024 09:46:44 -0800 (PST) Received: from ?IPV6:2001:8a0:f918:ab00:e0e8:3620:43e9:e37a? ([2001:8a0:f918:ab00:e0e8:3620:43e9:e37a]) by smtp.gmail.com with ESMTPSA id g16-20020a05600c311000b004127942bcd6sm1424790wmo.7.2024.02.21.09.46.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Feb 2024 09:46:43 -0800 (PST) Message-ID: <99297723-e4b9-4b94-803f-4998bcdf794a@palves.net> Date: Wed, 21 Feb 2024 17:46:41 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] gdb: remove some GCC version checks Content-Language: en-US To: Simon Marchi , Kevin Buettner , Simon Marchi Cc: gdb-patches@sourceware.org References: <20240221164709.54212-1-simon.marchi@efficios.com> <20240221100928.62ad46c4@f39-zbm-amd> <499636ca-75b0-4a4b-a685-4c84f4523665@simark.ca> From: Pedro Alves In-Reply-To: <499636ca-75b0-4a4b-a685-4c84f4523665@simark.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-02-21 17:36, Simon Marchi wrote: > On 2/21/24 12:09, Kevin Buettner wrote: >> On Wed, 21 Feb 2024 11:46:51 -0500 >> Simon Marchi wrote: >> >>> New in v2: >>> >>> - remove changes to nat/x86-gcc-cpuid.h >>> - adjust indentation in tracepoint.h >>> >>> Since we now require C++17, and therefore gcc >= 9, it's no longer >>> useful to have gcc version checks for older gcc version. >> >> Both patches LGTM. >> >> Reviewed-by: Kevin Buettner >> > > Thanks. I'll wait for a confirmation from Pedro as well, since he gave > comment on v1. > LGTM. Approved-By: Pedro Alves